From 10f8a2781359d6e7acf7f50ef97d36ab4541c8d3 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Sat, 19 Nov 2022 03:02:37 +0000 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne --- engine/src/main/java/org/n52/javaps/utils/IOUtils.java | 4 ++-- .../src/main/java/org/n52/javaps/utils/LargeBufferStream.java | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/engine/src/main/java/org/n52/javaps/utils/IOUtils.java b/engine/src/main/java/org/n52/javaps/utils/IOUtils.java index c9e07972..06ecde77 100644 --- a/engine/src/main/java/org/n52/javaps/utils/IOUtils.java +++ b/engine/src/main/java/org/n52/javaps/utils/IOUtils.java @@ -71,7 +71,7 @@ public static File writeBase64ToFile(InputStream input, public static File writeStreamToFile(InputStream inputStream, String extension) throws IOException { - File file = File.createTempFile(FILE + UUID.randomUUID(), "." + extension); + File file = Files.createTempFile(FILE + UUID.randomUUID(), "." + extension).toFile(); return writeStreamToFile(inputStream, extension, file); } @@ -112,7 +112,7 @@ public static File writeStreamToFile(InputStream inputStream, * if the zipping process fails. */ public static File zip(File... files) throws IOException { - File zip = File.createTempFile("zip" + UUID.randomUUID(), ".zip"); + File zip = Files.createTempFile("zip" + UUID.randomUUID(), ".zip").toFile(); try (ZipOutputStream out = new ZipOutputStream(new FileOutputStream(zip))) { byte[] buffer = new byte[4096]; diff --git a/engine/src/main/java/org/n52/javaps/utils/LargeBufferStream.java b/engine/src/main/java/org/n52/javaps/utils/LargeBufferStream.java index 3aa72280..220fc2b1 100644 --- a/engine/src/main/java/org/n52/javaps/utils/LargeBufferStream.java +++ b/engine/src/main/java/org/n52/javaps/utils/LargeBufferStream.java @@ -21,6 +21,7 @@ import java.io.FileOutputStream; import java.io.IOException; import java.io.OutputStream; +import java.nio.file.Files; import java.util.ArrayList; /** @@ -127,7 +128,7 @@ private boolean reachedInCoreLimit() throws IOException { return false; } - onDiskFile = File.createTempFile("jgit_", ".buffer"); + onDiskFile = Files.createTempFile("jgit_", ".buffer").toFile(); diskOut = new FileOutputStream(onDiskFile); final Block last = blocks.remove(blocks.size() - 1);