Fix linter warnings

Author: nburmaso

PWGUD/Core/UPCHelpers.h

@@ -22,8 +22,6 @@
 #include "CommonConstants/LHCConstants.h"
 #include "Framework/AnalysisDataModel.h"
 
-#include "TLorentzVector.h"
-
 using BCsWithBcSels = o2::soa::Join<o2::aod::BCs, o2::aod::BcSels>;
 
 using ForwardTracks = o2::soa::Join<o2::aod::FwdTracks, o2::aod::FwdTracksCov>;
@@ -96,13 +94,15 @@ struct FITInfo {
   int32_t distClosestBcT0A = 999;
 };
 
+constexpr double AbsorberMid = 26.5;
+
 template <typename T, typename TSelectorsArray>
 void applyFwdCuts(UPCCutparHolder& upcCuts, const T& track, TSelectorsArray& fwdSelectors)
 {
   fwdSelectors[kFwdSelPt] = track.pt() > upcCuts.getFwdPtLow() && track.pt() < upcCuts.getFwdPtHigh();                                                        // check pt
   fwdSelectors[kFwdSelEta] = track.eta() > upcCuts.getFwdEtaLow() && track.eta() < upcCuts.getFwdEtaHigh();                                                   // check pseudorapidity
   fwdSelectors[kFwdSelRabs] = track.rAtAbsorberEnd() > upcCuts.getMuonRAtAbsorberEndLow() && track.rAtAbsorberEnd() < upcCuts.getMuonRAtAbsorberEndHigh();    // check muon R
-  fwdSelectors[kFwdSelpDCA] = track.rAtAbsorberEnd() < 26.5 ? track.pDca() < upcCuts.getMuonPDcaHighFirst() : track.pDca() < upcCuts.getMuonPDcaHighSecond(); // check pDCA
+  fwdSelectors[kFwdSelpDCA] = track.rAtAbsorberEnd() < AbsorberMid ? track.pDca() < upcCuts.getMuonPDcaHighFirst() : track.pDca() < upcCuts.getMuonPDcaHighSecond(); // check pDCA
   fwdSelectors[kFwdSelChi2] = track.chi2() > upcCuts.getFwdChi2Low() && track.chi2() < upcCuts.getFwdChi2High();                                              // check chi2
 }
 
@@ -131,7 +131,7 @@ void applyBarrelCuts(UPCCutparHolder& upcCuts, const T& track, TSelectorsArray&
 
   if (upcCuts.getCheckMaxDcaXY()) {
     float dca = track.dcaXY();
-    float maxDCA = 0.0105f + 0.0350f / pow(track.pt(), 1.1f);
+    float maxDCA = 0.0105f + 0.0350f / std::pow(track.pt(), 1.1f);
     barrelSelectors[kBarrelSelDCAXY] = dca < maxDCA;
   } else {
     barrelSelectors[kBarrelSelDCAXY] = true;

PWGUD/TableProducer/CMakeLists.txt

@@ -42,7 +42,7 @@ o2physics_add_dpl_workflow(two-tracks-event-table-producer
                            COMPONENT_NAME Analysis)
 
 o2physics_add_dpl_workflow(fwdtrack-propagation
-                           SOURCES fwdTrackPropagation.cxx
+                           SOURCES fwdtrackPropagation.cxx
                            PUBLIC_LINK_LIBRARIES O2::Framework O2Physics::AnalysisCore O2::GlobalTracking
                            COMPONENT_NAME Analysis)
 

…UD/TableProducer/fwdTrackPropagation.cxx …UD/TableProducer/fwdtrackPropagation.cxxPWGUD/TableProducer/fwdTrackPropagation.cxx renamed to PWGUD/TableProducer/fwdtrackPropagation.cxx PWGUD/TableProducer/fwdTrackPropagation.cxx renamed to PWGUD/TableProducer/fwdtrackPropagation.cxx

@@ -27,12 +27,15 @@
 #include "Framework/runDataProcessing.h"
 #include "GlobalTracking/MatchGlobalFwd.h"
 #include "MCHTracking/TrackExtrap.h"
-#include "MCHTracking/TrackParam.h"
 #include "ReconstructionDataFormats/TrackFwd.h"
 
 #include "Math/SMatrix.h"
 #include "TGeoGlobalMagField.h"
 
+#include <map>
+#include <string>
+#include <vector>
+
 using namespace o2::framework;
 using namespace o2::framework::expressions;
 using o2::aod::fwdtrack::ForwardTrackTypeEnum;

PWGUD/TableProducer/upcCandProducerMuon.cxx

@@ -16,7 +16,6 @@
 
 #include "PWGUD/Core/UPCCutparHolder.h"
 #include "PWGUD/Core/UPCHelpers.h"
-#include "PWGUD/DataModel/UDTables.h"
 
 #include "CCDB/BasicCCDBManager.h"
 #include "CommonConstants/LHCConstants.h"
@@ -35,6 +34,7 @@
 
 #include <algorithm>
 #include <map>
+#include <string>
 #include <vector>
 
 using namespace o2::framework;
@@ -94,7 +94,6 @@ struct UpcCandProducerMuon {
 
   bool cut(const o2::dataformats::GlobalFwdTrack& pft, const ForwardTracks::iterator& fwdTrack)
   {
-    constexpr double AbsorberMid = 26.5;
     histRegistry.fill(HIST("MuonsSelCounter"), upchelpers::kFwdSelAll, 1);
     auto pt = pft.getPt();
     auto eta = pft.getEta();
@@ -104,7 +103,7 @@ struct UpcCandProducerMuon {
     bool passPt = pt > fUpcCuts.getFwdPtLow() && pt < fUpcCuts.getFwdPtHigh();
     bool passEta = eta > fUpcCuts.getFwdEtaLow() && eta < fUpcCuts.getFwdEtaHigh();
     bool passRabs = rabs > fUpcCuts.getMuonRAtAbsorberEndLow() && rabs < fUpcCuts.getMuonRAtAbsorberEndHigh();
-    bool passPDca = rabs < AbsorberMid ? pdca < fUpcCuts.getMuonPDcaHighFirst() : pdca < fUpcCuts.getMuonPDcaHighSecond();
+    bool passPDca = rabs < upchelpers::AbsorberMid ? pdca < fUpcCuts.getMuonPDcaHighFirst() : pdca < fUpcCuts.getMuonPDcaHighSecond();
     bool passChi2 = chi2 > fUpcCuts.getFwdChi2Low() && chi2 < fUpcCuts.getFwdChi2High();
     if (passPt)
       histRegistry.fill(HIST("MuonsSelCounter"), upchelpers::kFwdSelPt, 1);