Implement Vit comments

Author: Marcello Di Costanzo

ALICE3/DataModel/A3DecayFinderTables.h

@@ -66,10 +66,6 @@ DECLARE_SOA_COLUMN(ZSecondaryVertex, zSecondaryVertex, double); //!
 DECLARE_SOA_DYNAMIC_COLUMN(RSecondaryVertex, rSecondaryVertex,  //!
                            [](float xVtxS, float yVtxS) -> float { return RecoDecay::sqrtSumOfSquares(xVtxS, yVtxS); });
 DECLARE_SOA_COLUMN(Chi2PCA, chi2PCA, float); //! sum of (non-weighted) distances of the secondary vertex to its prongs
-// Prong index columns
-DECLARE_SOA_INDEX_COLUMN_FULL(Prong0, prong0, int, Tracks, "_0"); //! Index to first prong
-DECLARE_SOA_INDEX_COLUMN_FULL(Prong1, prong1, int, Tracks, "_1"); //! Index to second prong
-DECLARE_SOA_INDEX_COLUMN_FULL(Prong2, prong2, int, Tracks, "_2"); //! Index to third prong
 // prong properties
 DECLARE_SOA_COLUMN(PxProng0, pxProng0, float); //!
 DECLARE_SOA_COLUMN(PyProng0, pyProng0, float); //!
@@ -340,7 +336,6 @@ DECLARE_SOA_TABLE(Alice3Cand3Ps, "AOD", "ALICE3CAND3P", //!
                   a3_hf_cand_3prong::Phi,
                   a3_hf_cand_3prong::Pt,
                   // prong properties
-                  a3_hf_cand::Prong0Id, a3_hf_cand::Prong1Id, a3_hf_cand::Prong2Id,
                   a3_hf_cand::PxProng0, a3_hf_cand::PyProng0, a3_hf_cand::PzProng0, // proton track
                   a3_hf_cand::PxProng1, a3_hf_cand::PyProng1, a3_hf_cand::PzProng1, // kaon track
                   a3_hf_cand::PxProng2, a3_hf_cand::PyProng2, a3_hf_cand::PzProng2, // pion track

ALICE3/ML/MlResponse3Prong.h ALICE3/ML/HfMlResponse3Prong.hALICE3/ML/MlResponse3Prong.h renamed to ALICE3/ML/HfMlResponse3Prong.h

@@ -13,13 +13,11 @@
 /// \brief Class to compute the ML response for HF 3-prong candidates
 /// \author Marcello Di Costanzo <marcello.di.costanzo@cern.ch>, Polytechnic University of Turin and INFN Turin
 
-#ifndef ALICE3_ML_MLRESPONSE3PRONG_H_
-#define ALICE3_ML_MLRESPONSE3PRONG_H_
+#ifndef ALICE3_ML_HFMLRESPONSE3PRONG_H_
+#define ALICE3_ML_HFMLRESPONSE3PRONG_H_
 
 #include "Tools/ML/MlResponse.h"
 
-#include <CommonConstants/PhysicsConstants.h>
-
 #include <cstdint>
 #include <map>
 #include <string>
@@ -98,13 +96,13 @@ enum class InputFeatures3Prong : uint8_t {
 };
 
 template <typename TypeOutputScore = float>
-class MlResponse3Prong : public MlResponse<TypeOutputScore>
+class HfMlResponse3Prong : public MlResponse<TypeOutputScore>
 {
  public:
   /// Default constructor
-  MlResponse3Prong() = default;
+  HfMlResponse3Prong() = default;
   /// Default destructor
-  virtual ~MlResponse3Prong() = default;
+  virtual ~HfMlResponse3Prong() = default;
 
   /// Method to get the input features vector needed for ML inference
   /// \tparam T1 type of the 3-prong candidate
@@ -221,4 +219,4 @@ class MlResponse3Prong : public MlResponse<TypeOutputScore>
 #undef FILL_MAP_3PRONG
 #undef CHECK_AND_FILL_ML_ALICE3
 
-#endif // ALICE3_ML_MLRESPONSE3PRONG_H_
+#endif // ALICE3_ML_HFMLRESPONSE3PRONG_H_

ALICE3/TableProducer/alice3-decayfinder.cxx

@@ -1021,7 +1021,6 @@ struct alice3decayFinder {
                           cand3prong.eta,
                           cand3prong.phi,
                           cand3prong.pt,
-                          prong0.globalIndex(), prong1.globalIndex(), prong2.globalIndex(),
                           cand3prong.Pdaug2[0], cand3prong.Pdaug2[1], cand3prong.Pdaug2[2],
                           cand3prong.Pdaug1[0], cand3prong.Pdaug1[1], cand3prong.Pdaug1[2],
                           cand3prong.Pdaug0[0], cand3prong.Pdaug0[1], cand3prong.Pdaug0[2],

ALICE3/TableProducer/alice3HfSelector3Prong.cxx

@@ -22,9 +22,12 @@
 #include "ALICE3/DataModel/OTFRICH.h"
 #include "ALICE3/DataModel/OTFTOF.h"
 #include "ALICE3/DataModel/RICH.h"
-#include "ALICE3/ML/MlResponse3Prong.h"
 #include "ALICE3/Utils/utilsHfAlice3.h"
 #include "ALICE3/Utils/utilsSelectionsAlice3.h"
+#include "ALICE3/ML/HfMlResponse3Prong.h"
+
+#include "PWGHF/Core/SelectorCuts.h"
+#include "PWGHF/DataModel/CandidateSelectionTables.h"
 
 #include <CCDB/CcdbApi.h>
 #include <CommonConstants/PhysicsConstants.h>
@@ -98,7 +101,7 @@ struct Alice3HfSelector3Prong {
   Configurable<bool> loadModelsFromCCDB{"loadModelsFromCCDB", false, "Flag to enable or disable the loading of models from CCDB"};
 
   HfHelperAlice3 hfHelper;
-  o2::analysis::MlResponse3Prong<float> mlResponse;
+  o2::analysis::HfMlResponse3Prong<float> mlResponse;
   o2::ccdb::CcdbApi ccdbApi;
 
   using CandsLc = soa::Join<aod::Alice3Cand3Ps, aod::Alice3PidLcs>;

ALICE3/Utils/utilsHfAlice3.h

@@ -18,21 +18,6 @@
 #define ALICE3_UTILS_UTILSHFALICE3_H_
 
 #include "PWGHF/Core/HfHelper.h"
-#include "PWGHF/Utils/utilsAnalysis.h"
-
-#include "Common/Core/RecoDecay.h"
-#include "Common/Core/TrackSelectorPID.h"
-
-#include <CommonConstants/MathConstants.h>
-#include <CommonConstants/PhysicsConstants.h>
-
-#include <Math/GenVector/Boost.h>
-#include <Math/Vector4D.h> // IWYU pragma: keep (do not replace with Math/Vector4Dfwd.h)
-#include <Math/Vector4Dfwd.h>
-
-#include <array>
-#include <cmath>
-#include <vector>
 
 namespace o2::analysis
 {