Skip to content

Commit dcdae10

Browse files
committed
Use alternative image with newest version
IRC we needed the development branch for PHPCS support for PHP8.4, PHP8.4 support is still not backported (even now PHP8.5 is out). We switch to another image as we now install the tool ourselves in our image. We used the default container as it would make maintenance easier but now we needed to patch the composer.json a couple of times so doing this ourselves from the start is easier.
1 parent 2357c0c commit dcdae10

File tree

2 files changed

+2
-29
lines changed

2 files changed

+2
-29
lines changed

.github/jobs/fix_pipelinecomponents_image.sh

Lines changed: 0 additions & 24 deletions
This file was deleted.

.github/workflows/codestyle.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,15 @@ jobs:
4343
phpcs_compatibility:
4444
runs-on: ubuntu-latest
4545
container:
46-
image: pipelinecomponents/php-codesniffer:latest
46+
image: domjudge/gitlabci:24.04
4747
strategy:
4848
matrix:
4949
PHPVERSION: ["8.1", "8.2", "8.3", "8.4"]
5050
steps:
51-
- run: apk add git
5251
- uses: actions/checkout@v4
53-
- name: Various fixes to this image
54-
run: .github/jobs/fix_pipelinecomponents_image.sh
5552
- name: Detect compatibility with supported PHP version
5653
run: >
57-
phpcs -s -p --colors
54+
/vendor/bin/phpcs -s -p --colors
5855
--standard=PHPCompatibility
5956
--extensions=php
6057
--runtime-set testVersion ${{ matrix.PHPVERSION }}

0 commit comments

Comments
 (0)