From 4c42e95974d3cfd74630727a298928130b10b0f3 Mon Sep 17 00:00:00 2001 From: Michael Vasseur <14887731+vmcj@users.noreply.github.com> Date: Sun, 21 Dec 2025 13:02:31 +0100 Subject: [PATCH 1/3] Double & float are the same in PHP See: - https://www.php.net/manual/en/migration85.deprecated.php - https://php.watch/versions/8.5/boolean-double-integer-binary-casts-deprecated Non-canonical cast names (boolean), (integer), (double), and (binary) have been deprecated, use (bool), (int), (float), and (string) respectively. --- webapp/src/Controller/Jury/RejudgingController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapp/src/Controller/Jury/RejudgingController.php b/webapp/src/Controller/Jury/RejudgingController.php index da05c10a79..32d7eeef73 100644 --- a/webapp/src/Controller/Jury/RejudgingController.php +++ b/webapp/src/Controller/Jury/RejudgingController.php @@ -126,7 +126,7 @@ public function indexAction(): Response $status = $rejudging->getValid() ? 'applied' : 'canceled'; $sort_order = 2; } elseif ($todo > 0) { - $perc = (int)(100 * ((double)$done / (double)($done + $todo))); + $perc = (int)(100 * ((float)$done / (float)($done + $todo))); $status = sprintf("%d%% done", $perc); $sort_order = 0; } else { From 71e1eac990178ff68639508d9ebfab7f57fbc5c1 Mon Sep 17 00:00:00 2001 From: Michael Vasseur <14887731+vmcj@users.noreply.github.com> Date: Sun, 21 Dec 2025 13:06:08 +0100 Subject: [PATCH 2/3] Remove unneeded `noop` call to imagedestroy See: https://www.php.net/manual/en/migration85.deprecated.php The imagedestroy() function has been deprecated, as GdImage objects are freed automatically. --- webapp/src/Utils/Utils.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/webapp/src/Utils/Utils.php b/webapp/src/Utils/Utils.php index 9e07e13944..7b0c1e77fb 100644 --- a/webapp/src/Utils/Utils.php +++ b/webapp/src/Utils/Utils.php @@ -761,9 +761,6 @@ public static function getImageThumb(string $image, int $thumbMaxSize, string $t return false; } - imagedestroy($orig); - imagedestroy($thumb); - return $thumbstr; } From f1de3957285e2e0fc9d1621531aaf29d7db2179b Mon Sep 17 00:00:00 2001 From: Michael Vasseur <14887731+vmcj@users.noreply.github.com> Date: Sun, 21 Dec 2025 13:07:56 +0100 Subject: [PATCH 3/3] Remove `noop` call to finfo_close See: https://www.php.net/manual/en/migration85.deprecated.php The finfo_close() function has been deprecated. As finfo objects are freed automatically. --- webapp/src/Utils/Utils.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/webapp/src/Utils/Utils.php b/webapp/src/Utils/Utils.php index 7b0c1e77fb..54f51752f7 100644 --- a/webapp/src/Utils/Utils.php +++ b/webapp/src/Utils/Utils.php @@ -994,8 +994,6 @@ public static function getTextType(string $clientName, string $realPath): ?strin [$type] = explode('; ', finfo_file($finfo, $realPath)); - finfo_close($finfo); - switch ($type) { case 'application/pdf': $textType = 'pdf';