GetDiscoveredScripts throws a NullReferenceException when using WithScriptsAndCodeEmbeddedInAssembly

[blankensteiner]

Hi

Let's start with the code (using the latest version of DbUp in a .NET Core 3.1 application).

var upgradeEngine = DeployChanges.To
                    .SqlDatabase("snip")
                    .LogToConsole()
                    .WithScriptsAndCodeEmbeddedInAssembly(Assembly.GetExecutingAssembly())
                    .Build();

Console.WriteLine("Discovered scripts:");
foreach (var script in upgradeEngine.GetDiscoveredScripts())
    Console.WriteLine("\t" + script.Name);

Calling GetDiscoveredScripts or GetExecutedButNotDiscoveredScripts will both call GetDiscoveredScriptsAsEnumerable, which in turn will call EmbeddedScriptAndCodeProvider.GetScripts which will then call ScriptsFromScriptClasses. This is a problem since it will call DatebaseConnectionManager.ExecuteCommandsWithManagedConnection and here the 'transactionStrategy' field is null, because OperationStarting has never been called.

[narve]

Confirmed, this is a showstopper right now :(

Did this work in 4.2.0?

Update: Worked in 4.2.0, downgrading.

[ZJouba]

Had a similar issue https://stackoverflow.com/questions/64066692/getting-a-nullreferenceexception-when-using-dotnet-run-project-option
Downgrading to 4.2.0 also fixed it

[jhumphries83]

Downgrading to dbup-sqlserver 4.2.0 didn't work for me. In fact the GetDiscoveredScripts method doesn't exist in 4.2.0.

It looks as though it was introduced in 4.3.0 and has not worked with WithScriptsAndCodeEmbeddedInAssembly since then.

[JasonTheProgrammer]

It's possible to work around this issue by triggering initialisation of the 'transactionStrategy' field.

var upgradeConfig = DeployChanges.To
                    .SqlDatabase("snip")
                    .LogToConsole()
                    .WithScriptsAndCodeEmbeddedInAssembly(Assembly.GetExecutingAssembly())
                    .BuildConfiguration();
var upgradeEngine = new UpgradeEngine(upgradeConfig);

// This ultimately ensures 'transactionStrategy' is no longer null.
using var disposableOperation = upgradeConfig .ConnectionManager.OperationStarting(
   new DbUp.Engine.Output.NoOpUpgradeLog(),
   new List<SqlScript>());

Console.WriteLine("Discovered scripts:");
foreach (var script in upgradeEngine.GetDiscoveredScripts())
    Console.WriteLine("\t" + script.Name);