BGPD: FRR is Shutting Sessions due to OTC Routes

[dylanjamesdev]

Description

BGPD: FRR is Shutting Sessions due to OTC Routes

Dec 13 06:04:08 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2: BGP type 35 length 1024 is too large, attribute total length is 82.  attr_endp is 0x7f6ae7055286.  endp is 0x7f6ae7054e89

Dec 13 06:04:08 core1.mci.tritan-bb.net bgpd[1778]: %NOTIFICATION: sent to neighbor 2602:291::2 3/5 (UPDATE Message Error/Attribute Length Error) 6 bytes 23 04 

Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:6562::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:6460::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:61e2::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:6120::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:76c0::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:7520::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:74a2::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:73a2::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:71a0::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:70c4::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:70e2::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:7a20::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:7802::/47 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8800::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8810::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8820::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8080::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8090::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:80a0::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:80c0::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:80d0::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8000::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8010::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8020::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8030::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8040::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8050::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8060::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8070::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8600::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd 2001:1388:8610::/44 IPv6 unicast
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: AS_SET and AS_CONFED_SET are deprecated from 2602:291::2(Unknown)
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2: Attribute AS_PATH, parse error - treating as withdrawal
Dec 13 06:04:02 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) rcvd UPDATE with errors in attr(s)!! Withdrawing route.
Dec 13 06:04:08 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2: BGP type 35 length 1024 is too large, attribute total length is 82.  attr_endp is 0x7f6ae7055286.  endp is 0x7f6ae7054e89
Dec 13 06:04:08 core1.mci.tritan-bb.net bgpd[1778]: %NOTIFICATION: sent to neighbor 2602:291::2 3/5 (UPDATE Message Error/Attribute Length Error) 6 bytes 23 04
Dec 13 06:04:08 core1.mci.tritan-bb.net bgpd[1778]: bgp_process_packet: BGP UPDATE receipt failed for peer: 2602:291::2
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 [FSM] Timer (connect timer (30s) expire for Unknown)
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 [FSM] ConnectRetry_timer_expired (Active->Connect), fd -1 for Unknown
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 [Event] Connect start to 2602:291::2 fd 140
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 [FSM] Non blocking connect waiting result, fd 140 for Outgoing
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 fd 140 went from Active to Connect for Outgoing
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 [FSM] TCP_connection_open (Connect->OpenSent), fd 140 for Outgoing
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 open active, local address 2602:291::1 for Outgoing
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 Sending hostname cap with hn = core1.mci.tritan-bb.net, dn = mci.tritan-bb.net
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 Sending Software Version cap, value: FRRouting/10.5.0
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2(Unknown) fd 140 sending OPEN, version 4, my as 393577, holdtime 180, id 23.142.248.1
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 fd 140 went from Connect to OpenSent for Outgoing
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 [Error] bgp_read_packet error: Connection reset by peer
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 [Event] BGP error 7 on fd 140
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 [FSM] TCP_fatal_error (OpenSent->Active), fd 140 for Outgoing
Dec 13 06:04:44 core1.mci.tritan-bb.net bgpd[1778]: 2602:291::2 fd -1 went from OpenSent to Active for Unknown
root@core1:~# 

Version

uting 10.5.0 (core1.mci.tritan-bb.net) on Linux(6.1.0-38-amd64).
Copyright 1996-2005 Kunihiro Ishiguro, et al.
configured with:
    '--build=x86_64-linux-gnu' '--prefix=/usr' '--includedir=${prefix}/include' '--mandir=${prefix}/share/man' '--infodir=${prefix}/share/info' '--sysconfdir=/etc' '--localstatedir=/var' '--disable-option-checking' '--disable-silent-rules' '--libdir=${prefix}/lib/x86_64-linux-gnu' '--libexecdir=${prefix}/lib/x86_64-linux-gnu' '--disable-maintainer-mode' '--sbindir=/usr/lib/frr' '--with-vtysh-pager=/usr/bin/pager' '--libdir=/usr/lib/x86_64-linux-gnu/frr' '--with-moduledir=/usr/lib/x86_64-linux-gnu/frr/modules' '--disable-dependency-tracking' '--enable-rpki' '--disable-scripting' '--enable-pim6d' '--disable-grpc' '--disable-address-sanitizer' '--with-libpam' '--enable-doc' '--enable-doc-html' '--enable-snmp' '--enable-fpm' '--disable-protobuf' '--disable-zeromq' '--enable-ospfapi' '--enable-bgp-vnc' '--enable-multipath=256' '--enable-pcre2posix' '--enable-user=frr' '--enable-group=frr' '--enable-vty-group=frrvty' '--enable-configfile-mask=0640' '--enable-logfile-mask=0640' 'build_alias=x86_64-linux-gnu' 'PYTHON=python3'
core1.mci.tritan-bb.net# show version
FRRouting 10.5.0 (core1.mci.tritan-bb.net) on Linux(6.1.0-38-amd64).

How to reproduce

Send an OTC route to this version of FRR.

Expected behavior

It to either reject the individual route or install it, not shut down entire sessions.

Actual behavior

FRR shuts down the entire session, citing that it received an invalid attribute.

Additional context

No response

Checklist

• I have searched the open issues for this bug.
• I have not included sensitive information in this report.

[ton31337]

@dylanjamesdev, what is on the other side? FRR or any other daemon? Could you provide the configurations/topology and/or pcap file would be handy as well.