Skip to content
This repository was archived by the owner on Nov 20, 2020. It is now read-only.
This repository was archived by the owner on Nov 20, 2020. It is now read-only.

Change git URL #229

@sprowell

Description

@sprowell

Did not see this elsewhere, sorry if missed.

Two suggestions.

(1) I would suggest changing the URL used in the documentation and in the install.sh script to use https instead of git. This is more likely to work well through firewalls and the like. For example, git fails with the following from my work machine.

Cloning into '_bootstrap'...
fatal: unable to connect to github.com:
github.com[0: 192.30.253.112]: errno=Connection refused
github.com[1: 192.30.253.113]: errno=Connection refused

(2) Pursuant to the above, and way less important, check the output of the git command before moving on. Otherwise you end with the following error.

install.sh: line 15: cd: _bootstrap: No such file or directory

So, to summarize, I recommend replacing this line:

git clone  --recursive git://github.com/LuaDist/bootstrap.git _bootstrap

with this line:

git clone  --recursive https://github.com/LuaDist/bootstrap.git _bootstrap || exit 1

Added: It wasn't clear, but I think this change should be made throughout the scripts, so also in config.lua, for instance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions