fix #1889

Author: sumneko

changelog.md

@@ -4,9 +4,11 @@
 * `CHG` completion: don't show loading process
 * `FIX` [#1886]
 * `FIX` [#1895]
+* `FIX` [#1889]
 
 [#1886]: https://github.com/LuaLS/lua-language-server/issues/1886
 [#1895]: https://github.com/LuaLS/lua-language-server/issues/1895
+[#1889]: https://github.com/LuaLS/lua-language-server/issues/1889
 
 ## 3.6.10
 `2023-2-7`

script/config/template.lua

@@ -210,6 +210,7 @@ local template = {
                                                     'assert',
                                                     'error',
                                                     'type',
+                                                    'os.exit',
                                                 }
                                             ),
     ['Lua.runtime.meta']                    = Type.String >> '${version} ${language} ${encoding}',

script/core/diagnostics/missing-return.lua

@@ -7,7 +7,7 @@ local await  = require 'await'
 ---@param block parser.object
 ---@return boolean
 local function hasReturn(block)
-    if block.hasReturn or block.hasError then
+    if block.hasReturn or block.hasExit then
         return true
     end
     if block.type == 'if' then

script/core/diagnostics/unreachable-code.lua

@@ -23,7 +23,7 @@ end
 ---@param block parser.object
 ---@return boolean
 local function hasReturn(block)
-    if block.hasReturn or block.hasError then
+    if block.hasReturn or block.hasExit then
         return true
     end
     if block.type == 'if' then

script/parser/compile.lua

@@ -118,6 +118,7 @@ local Specials = {
     ['assert']       = true,
     ['error']        = true,
     ['type']         = true,
+    ['os.exit']      = true,
 }
 
 local UnarySymbol = {
@@ -2899,14 +2900,15 @@ local function compileExpAsAction(exp)
     end
 
     if exp.type == 'call' then
-        if exp.node.special == 'error' then
+        if exp.node.special == 'error'
+        or exp.node.special == 'os.exit' then
             for i = #Chunk, 1, -1 do
                 local block = Chunk[i]
                 if block.type == 'ifblock'
                 or block.type == 'elseifblock'
                 or block.type == 'elseblock'
                 or block.type == 'function' then
-                    block.hasError = true
+                    block.hasExit = true
                     break
                 end
             end

script/parser/guide.lua

@@ -72,7 +72,7 @@ local type         = type
 ---@field hasGoTo?              true
 ---@field hasReturn?            true
 ---@field hasBreak?             true
----@field hasError?             true
+---@field hasExit?              true
 ---@field [integer]             parser.object|any
 ---@field package _root          parser.object
 

script/vm/tracer.lua

@@ -369,7 +369,7 @@ local lookIntoChild = util.switch()
                 local neverReturn = subBlock.hasReturn
                                 or  subBlock.hasGoTo
                                 or  subBlock.hasBreak
-                                or  subBlock.hasError
+                                or  subBlock.hasExit
                 if neverReturn then
                     mergedNode = true
                 else

test/type_inference/init.lua

@@ -2620,6 +2620,17 @@ end
 print(<?n?>)
 ]]
 
+TEST 'integer' [[
+---@type integer?
+local n
+
+if not n then
+    os.exit()
+end
+
+print(<?n?>)
+]]
+
 TEST 'table' [[
 ---@type table?
 local n