Merge pull request #3298 from halflifefan/max-fields-count

Made the hardcoded completion field limit configurable

Author: sumneko

changelog.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 <!-- Add all new changes here. They will be moved under a version at release -->
+* `NEW` Added `completion.maxSuggestCount` which lets you increase the amount of fields to analyze before requiring more specific input
 * `New` Omit parameter hints when the argument name matches
 * `FIX` Fix a typo in `no-unknown` diagnostic message
 * `FIX` Autodoc generation so it does not include documentation for builtin Lua language features

locale/en-us/setting.lua

@@ -178,6 +178,8 @@ config.completion.showWord.Disable       =
 "Do not display context words."
 config.completion.autoRequire            =
 "When the input looks like a file name, automatically `require` this file."
+config.completion.maxSuggestCount        =
+"Maximum number of fields to analyze for completions. When an object has more fields than this limit, completions will require more specific input to appear."
 config.completion.showParams             =
 "Display parameters in completion list. When the function has multiple definitions, they will be displayed separately."
 config.completion.requireSeparator       =

script/config/template.lua

@@ -347,6 +347,7 @@ local template = {
                                                 'Disable',
                                             },
     ['Lua.completion.autoRequire']          = Type.Boolean >> true,
+    ['Lua.completion.maxSuggestCount']      = Type.Integer >> 100,
     ['Lua.completion.showParams']           = Type.Boolean >> true,
     ['Lua.completion.requireSeparator']     = Type.String  >> '.',
     ['Lua.completion.postfix']              = Type.String  >> '@',

script/core/completion/completion.lua

@@ -565,8 +565,9 @@ local function checkFieldOfRefs(refs, state, word, startPos, position, parent, o
     local fields = {}
     local funcs  = {}
     local count  = 0
+    local maxSuggestCount = config.get(state.uri, 'Lua.completion.maxSuggestCount')
     for _, src in ipairs(refs) do
-        if count > 100 then
+        if count > maxSuggestCount then
             results.incomplete = true
             break
         end