Clean-up: use local variable instead of repeated function call

alxvth · alxvth · commit b402206320ec · 2025-10-27T14:59:44.000+01:00
diff --git a/src/ColoringAction.cpp b/src/ColoringAction.cpp
@@ -281,7 +281,8 @@ void ColoringAction::updateScatterplotWidgetColorMap()
     {
         case ScatterplotWidget::SCATTERPLOT:
         {
-            if (_colorByAction.getCurrentIndex() == 0) {
+            const int32_t currentIndex = _colorByAction.getCurrentIndex();
+            if (currentIndex == 0) {
                 QPixmap colorPixmap(1, 1);
 
                 colorPixmap.fill(_constantColorAction.getColor());
@@ -290,7 +291,7 @@ void ColoringAction::updateScatterplotWidgetColorMap()
                 scatterplotWidget.setScalarEffect(PointEffect::Color);
                 scatterplotWidget.setColoringMode(ScatterplotWidget::ColoringMode::Constant);
             }
-            else if (_colorByAction.getCurrentIndex() == 1) {
+            else if (currentIndex == 1) {
                 scatterplotWidget.setColorMap(_colorMap2DAction.getColorMapImage());
                 scatterplotWidget.setScalarEffect(PointEffect::Color2D);
                 scatterplotWidget.setColoringMode(ScatterplotWidget::ColoringMode::Scatter);

Original file line number	Diff line number	Diff line change
`@@ -281,7 +281,8 @@ void ColoringAction::updateScatterplotWidgetColorMap()`
`281`	`281`	`{`
`282`	`282`	`case ScatterplotWidget::SCATTERPLOT:`
`283`	`283`	`{`
`284`		`- if (_colorByAction.getCurrentIndex() == 0) {`
	`284`	`+ const int32_t currentIndex = _colorByAction.getCurrentIndex();`
	`285`	`+ if (currentIndex == 0) {`
`285`	`286`	`QPixmap colorPixmap(1, 1);`
`286`	`287`
`287`	`288`	`colorPixmap.fill(_constantColorAction.getColor());`
`@@ -290,7 +291,7 @@ void ColoringAction::updateScatterplotWidgetColorMap()`
`290`	`291`	`scatterplotWidget.setScalarEffect(PointEffect::Color);`
`291`	`292`	`scatterplotWidget.setColoringMode(ScatterplotWidget::ColoringMode::Constant);`
`292`	`293`	`}`
`293`		`- else if (_colorByAction.getCurrentIndex() == 1) {`
	`294`	`+ else if (currentIndex == 1) {`
`294`	`295`	`scatterplotWidget.setColorMap(_colorMap2DAction.getColorMapImage());`
`295`	`296`	`scatterplotWidget.setScalarEffect(PointEffect::Color2D);`
`296`	`297`	`scatterplotWidget.setColoringMode(ScatterplotWidget::ColoringMode::Scatter);`