URL encode when running ToString() (#242)

👍 @TylerLeonhardt you did just fine (I would have probably done worse! HA!)

Author: TylerLeonhardt

src/Protocol/DocumentUri.cs

@@ -175,7 +175,7 @@ public override string ToString()
             if (string.IsNullOrWhiteSpace(_stringValue))
             {
                 _stringValue =
-                    $"{Scheme}{_delimiter}{Authority}{Path}{(string.IsNullOrWhiteSpace(Query) ? "" : "?" + Query)}{(string.IsNullOrWhiteSpace(Fragment) ? "" : "#" + Fragment)}";
+                    $"{Scheme}{_delimiter}{Authority}{Uri.EscapeUriString(Path)}{(string.IsNullOrWhiteSpace(Query) ? "" : "?" + Uri.EscapeDataString(Query))}{(string.IsNullOrWhiteSpace(Fragment) ? "" : "#" + Uri.EscapeDataString(Fragment))}";
             }
 
             return _stringValue;

test/JsonRpc.Tests/InputHandlerTests.cs

@@ -128,8 +128,10 @@ public void ShouldPassInUtf8EncodedRequests()
         }
 
         [Theory]
-        [InlineData("{\"changes\": [{\"uri\": \"file:///Mörkö.cs\",\"type\": 1}]}")]
-        [InlineData("{\"textDocument\": {\"uri\": \"file://abc/123/树.cs\"}}")]
+        // Mörkö
+        [InlineData("{\"changes\": [{\"uri\": \"file:///M%C3%B6rk%C3%B6.cs\",\"type\": 1}]}")]
+        // 树
+        [InlineData("{\"textDocument\": {\"uri\": \"file://abc/123/%E6%A0%91.cs\"}}")]
         public void ShouldPassAdditionalUtf8EncodedReqeusts(string data)
         {
             var inputStream =

test/Lsp.Tests/DocumentUriTests.cs

@@ -50,7 +50,7 @@ public void NonStandardCharactersTest(string expected)
                     Changes = new Dictionary<DocumentUri, IEnumerable<TextEdit>>() {
                         {
                             // Mörkö
-                            new Uri("file:///abc/bc/123/Mörkö.cs"), new [] {
+                            new Uri("file:///abc/bc/123/M%C3%B6rk%C3%B6.cs"), new [] {
                                 new TextEdit() {
                                     NewText = "new text",
                                     Range = new Range(new Position(1, 1), new Position(2,2))

test/Lsp.Tests/Models/ApplyWorkspaceEditParamsTests.cs

@@ -1,7 +1,7 @@
 {
     "edit": {
         "changes": {
-            "file:///abc/bc/123/Mörkö.cs": [
+            "file:///abc/bc/123/M%C3%B6rk%C3%B6.cs": [
                 {
                     "range": {
                         "start": {

test/Lsp.Tests/Models/ApplyWorkspaceEditParamsTests_$NonStandardCharactersTest.json

@@ -56,7 +56,7 @@ public void NonStandardCharactersTest(string expected)
                 Range = new Range(new Position(1, 1), new Position(2, 2)),
                 TextDocument = new TextDocumentIdentifier() {
                     // 树 - Chinese for tree
-                    Uri = new Uri("file:///test/123/树.cs")
+                    Uri = new Uri("file:///test/123/%E6%A0%91.cs")
                 }
             };
             var result = Fixture.SerializeObject(model);

test/Lsp.Tests/Models/CodeActionParamsTests.cs

@@ -1,6 +1,6 @@
 {
     "textDocument": {
-        "uri": "file:///test/123/树.cs"
+        "uri": "file:///test/123/%E6%A0%91.cs"
     },
     "range": {
         "start": {

test/Lsp.Tests/Models/CodeActionParamsTests_$NonStandardCharactersTest.json

@@ -1,5 +1,5 @@
 {
     "textDocument": {
-        "uri": "file://abc/123/树.cs"
+        "uri": "file://abc/123/%E6%A0%91.cs"
     }
 }

test/Lsp.Tests/Models/CodeLensParamsTests_$NonStandardCharactersTest.json

@@ -1,7 +1,7 @@
 {
     "textDocument": {
         "version": 0,
-        "uri": "file:///C:/abc/Mörkö.cs"
+        "uri": "file:///C:/abc/M%C3%B6rk%C3%B6.cs"
     },
     "contentChanges": [
         {

test/Lsp.Tests/Models/DidChangeTextDocumentParamsTests_$NonStandardCharactersTest.json

@@ -38,7 +38,7 @@ public void NonStandardCharactersTest(string expected)
                     new FileEvent() {
                         Type = FileChangeType.Created,
                         // Mörkö
-                        Uri = new Uri("file:///Mörkö.cs")
+                        Uri = new Uri("file:///M%C3%B6rk%C3%B6.cs")
                     }
                 }
             };