Merge pull request #220 from OmniSharp/fix/cancellation

Added start of request call to request so that we don't leak cancella…

Author: bjorkstromm

src/JsonRpc/IRequestRouter.cs

@@ -10,6 +10,7 @@ public interface IRequestRouter
         Task RouteNotification(Notification notification, CancellationToken token);
         Task<ErrorResponse> RouteRequest(Request request, CancellationToken token);
         void CancelRequest(object id);
+        void StartRequest(object id);
     }
 
     public interface IRequestRouter<TDescriptor> : IRequestRouter

src/JsonRpc/InputHandler.cs

@@ -179,6 +179,7 @@ private void HandleRequest(string request)
                     var descriptor = _requestRouter.GetDescriptor(item.Request);
                     if (descriptor is null) continue;
                     var type = _requestProcessIdentifier.Identify(descriptor);
+                    _requestRouter.StartRequest(item.Request.Id);
                     _scheduler.Add(
                         type,
                         item.Request.Method,

src/JsonRpc/RequestRouterBase.cs

@@ -185,20 +185,21 @@ public virtual async Task<ErrorResponse> RouteRequest(TDescriptor descriptor, Re
 
         public void CancelRequest(object id)
         {
-            var idValue = GetId(id);
-            if (_requests.TryGetValue(idValue, out var cts))
+            if (_requests.TryGetValue(GetId(id), out var cts))
             {
                 cts.Cancel();
             }
             else
             {
-                cts = new CancellationTokenSource();
-                _requests.TryAdd(idValue, cts);
-                cts.Cancel();
                 _logger.LogDebug("Request {Id} was not found to cancel, stubbing it in.", id);
             }
         }
 
+        public void StartRequest(object id)
+        {
+            _requests.TryAdd(GetId(id), new CancellationTokenSource());
+        }
+
         private string GetId(object id)
         {
             if (id is string s)