Skip to content

Commit a78fa0a

Browse files
authored
Optional experimentId in Problem.add_measurement (#431)
Measurements don't require an experiment ID. Therefore, make `experimentId` optional in `Problem.add_measurement`. Also, require keyword arguments there.
1 parent 668fdf1 commit a78fa0a

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

petab/v2/core.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2035,9 +2035,10 @@ def add_parameter(
20352035
def add_measurement(
20362036
self,
20372037
obs_id: str,
2038-
experiment_id: str,
2038+
*,
20392039
time: float,
20402040
measurement: float,
2041+
experiment_id: str | None = None,
20412042
observable_parameters: Sequence[str | float] | str | float = None,
20422043
noise_parameters: Sequence[str | float] | str | float = None,
20432044
):

tests/v2/test_core.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,12 @@ def test_problem_from_yaml_multiple_files():
389389
problem.experiment_df, Path(tmpdir, f"experiments{i}.tsv")
390390
)
391391

392-
problem.add_measurement(f"observable{i}", f"experiment{i}", 1, 1)
392+
problem.add_measurement(
393+
f"observable{i}",
394+
experiment_id=f"experiment{i}",
395+
time=1,
396+
measurement=1,
397+
)
393398
petab.write_measurement_df(
394399
problem.measurement_df, Path(tmpdir, f"measurements{i}.tsv")
395400
)

0 commit comments

Comments
 (0)