From 73eb2586ffb5909930d1f67880602ecffec33d73 Mon Sep 17 00:00:00 2001 From: Max Ghenis Date: Wed, 3 Dec 2025 16:55:14 -0500 Subject: [PATCH] Fix invalid filing_status enum values in test files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixed the following invalid enum values that were silently converted to SINGLE (index 0) due to numpy.select's default behavior: - Utah: `single` (lowercase) → `SINGLE` - Missouri: `0` (numeric) → `SINGLE` - Colorado: `HEAD_OF_HOUSE_HOLD` (typo) → `HEAD_OF_HOUSEHOLD` - North Carolina: `WIDWO` (typo) → `SURVIVING_SPOUSE` These will cause test failures once policyengine-core#411 is merged, which adds validation to raise clear errors for invalid enum values. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- changelog_entry.yaml | 4 ++++ .../co_federal_deduction_addback.yaml | 4 ++-- .../mo_pension_and_ss_or_ssd_deduction_section_b.yaml | 2 +- .../mo_pension_and_ss_or_ssd_deduction_section_c.yaml | 2 +- .../tax/income/deductions/nc_itemized_deductions.yaml | 4 ++-- .../ss_benefits_credit/ut_ss_benefits_credit_max.yaml | 10 +++++----- 6 files changed, 15 insertions(+), 11 deletions(-) diff --git a/changelog_entry.yaml b/changelog_entry.yaml index e69de29bb2d..5c1040c552d 100644 --- a/changelog_entry.yaml +++ b/changelog_entry.yaml @@ -0,0 +1,4 @@ +- bump: patch + changes: + fixed: + - Fix invalid filing_status enum values in test files (lowercase 'single', numeric '0', typos 'WIDWO' and 'HEAD_OF_HOUSE_HOLD'). diff --git a/policyengine_us/tests/policy/baseline/gov/states/co/tax/income/additions/federal_deduction/co_federal_deduction_addback.yaml b/policyengine_us/tests/policy/baseline/gov/states/co/tax/income/additions/federal_deduction/co_federal_deduction_addback.yaml index 95a0ba48a2b..27001fe8fd6 100644 --- a/policyengine_us/tests/policy/baseline/gov/states/co/tax/income/additions/federal_deduction/co_federal_deduction_addback.yaml +++ b/policyengine_us/tests/policy/baseline/gov/states/co/tax/income/additions/federal_deduction/co_federal_deduction_addback.yaml @@ -203,7 +203,7 @@ input: state_code: CO co_federal_deduction_addback_required: true - filing_status: HEAD_OF_HOUSE_HOLD + filing_status: HEAD_OF_HOUSEHOLD itemized_taxable_income_deductions: 40_000 output: co_federal_deduction_addback: 10_000 @@ -304,7 +304,7 @@ input: state_code: CO co_federal_deduction_addback_required: true - filing_status: HEAD_OF_HOUSE_HOLD + filing_status: HEAD_OF_HOUSEHOLD taxable_income_deductions: 32_000 output: co_federal_deduction_addback: 20_000 diff --git a/policyengine_us/tests/policy/baseline/gov/states/mo/tax/income/deductions/mo_pension_and_ss_or_ssd_deduction/mo_pension_and_ss_or_ssd_deduction_section_b.yaml b/policyengine_us/tests/policy/baseline/gov/states/mo/tax/income/deductions/mo_pension_and_ss_or_ssd_deduction/mo_pension_and_ss_or_ssd_deduction_section_b.yaml index 62e2ec98051..f905020d2ed 100644 --- a/policyengine_us/tests/policy/baseline/gov/states/mo/tax/income/deductions/mo_pension_and_ss_or_ssd_deduction/mo_pension_and_ss_or_ssd_deduction_section_b.yaml +++ b/policyengine_us/tests/policy/baseline/gov/states/mo/tax/income/deductions/mo_pension_and_ss_or_ssd_deduction/mo_pension_and_ss_or_ssd_deduction_section_b.yaml @@ -4,7 +4,7 @@ input: mo_adjusted_gross_income: 0 tax_unit_taxable_social_security: 0 - filing_status: 0 + filing_status: SINGLE taxable_private_pension_income: 0 state_code: MO output: diff --git a/policyengine_us/tests/policy/baseline/gov/states/mo/tax/income/deductions/mo_pension_and_ss_or_ssd_deduction/mo_pension_and_ss_or_ssd_deduction_section_c.yaml b/policyengine_us/tests/policy/baseline/gov/states/mo/tax/income/deductions/mo_pension_and_ss_or_ssd_deduction/mo_pension_and_ss_or_ssd_deduction_section_c.yaml index 78b4d5330e1..c82a0c11ac2 100644 --- a/policyengine_us/tests/policy/baseline/gov/states/mo/tax/income/deductions/mo_pension_and_ss_or_ssd_deduction/mo_pension_and_ss_or_ssd_deduction_section_c.yaml +++ b/policyengine_us/tests/policy/baseline/gov/states/mo/tax/income/deductions/mo_pension_and_ss_or_ssd_deduction/mo_pension_and_ss_or_ssd_deduction_section_c.yaml @@ -4,7 +4,7 @@ input: mo_adjusted_gross_income: 0 taxable_social_security: 0 - filing_status: 0 + filing_status: SINGLE state_code: MO output: mo_pension_and_ss_or_ssd_deduction_section_c: 0.0 diff --git a/policyengine_us/tests/policy/baseline/gov/states/nc/tax/income/deductions/nc_itemized_deductions.yaml b/policyengine_us/tests/policy/baseline/gov/states/nc/tax/income/deductions/nc_itemized_deductions.yaml index cd8db93987e..8ecacbf5ae7 100644 --- a/policyengine_us/tests/policy/baseline/gov/states/nc/tax/income/deductions/nc_itemized_deductions.yaml +++ b/policyengine_us/tests/policy/baseline/gov/states/nc/tax/income/deductions/nc_itemized_deductions.yaml @@ -13,7 +13,7 @@ - name: Real estate taxes and mortgage capped period: 2022 input: - filing_status: WIDWO + filing_status: SURVIVING_SPOUSE mortgage_interest: 11_000 real_estate_taxes: 11_000 charitable_deduction: 0 @@ -25,7 +25,7 @@ - name: Real estate taxes and mortgage capped with medical and charitable period: 2022 input: - filing_status: WIDWO + filing_status: SURVIVING_SPOUSE mortgage_interest: 11_000 real_estate_taxes: 11_000 charitable_deduction: 1_000 diff --git a/policyengine_us/tests/policy/baseline/gov/states/ut/tax/income/credits/ss_benefits_credit/ut_ss_benefits_credit_max.yaml b/policyengine_us/tests/policy/baseline/gov/states/ut/tax/income/credits/ss_benefits_credit/ut_ss_benefits_credit_max.yaml index 99631c59600..9f8b8f14077 100644 --- a/policyengine_us/tests/policy/baseline/gov/states/ut/tax/income/credits/ss_benefits_credit/ut_ss_benefits_credit_max.yaml +++ b/policyengine_us/tests/policy/baseline/gov/states/ut/tax/income/credits/ss_benefits_credit/ut_ss_benefits_credit_max.yaml @@ -4,7 +4,7 @@ taxable_social_security: 5_000 ut_total_income: 20_000 tax_exempt_interest_income: 500 - filing_status: single + filing_status: SINGLE state_code: UT output: ut_ss_benefits_credit_max: 242.50 @@ -15,7 +15,7 @@ taxable_social_security: 5_000 ut_total_income: 30_000 tax_exempt_interest_income: 500 - filing_status: single + filing_status: SINGLE state_code: UT output: ut_ss_benefits_credit_max: 242.50 @@ -26,7 +26,7 @@ taxable_social_security: 5_000 ut_total_income: 25_000 tax_exempt_interest_income: 500 - filing_status: single + filing_status: SINGLE state_code: UT output: ut_ss_benefits_credit_max: 242.50 @@ -37,7 +37,7 @@ taxable_social_security: 0 ut_total_income: 20_000 tax_exempt_interest_income: 500 - filing_status: single + filing_status: SINGLE state_code: UT output: ut_ss_benefits_credit_max: 0 # no taxable social security income @@ -48,7 +48,7 @@ taxable_social_security: 100_000 ut_total_income: 20_000 tax_exempt_interest_income: 20_000 - filing_status: single + filing_status: SINGLE state_code: UT output: ut_ss_benefits_credit_max: 4_700