From db68a90beb9bccd5689152d8946ddd54f0ab1399 Mon Sep 17 00:00:00 2001 From: quentinchampenois <26109239+Quentinchampenois@users.noreply.github.com> Date: Mon, 4 Mar 2024 15:45:47 +0100 Subject: [PATCH 1/3] fix: Add specs for locale change in account form --- spec/spec_helper.rb | 17 +++++++++++++++++ spec/system/account_spec.rb | 1 + 2 files changed, 18 insertions(+) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index a30b234..fa1b4a9 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -7,3 +7,20 @@ Decidim::Dev.dummy_app_path = File.expand_path(File.join("spec", "decidim_dummy_app")) require "decidim/dev/test/base_spec_helper" + +Capybara.register_driver :headless_chrome do |app| + options = ::Selenium::WebDriver::Chrome::Options.new + options.args << "--headless=new" + options.args << "--no-sandbox" + options.args << if ENV["BIG_SCREEN_SIZE"].present? + "--window-size=1920,3000" + else + "--window-size=1920,1080" + end + options.args << "--ignore-certificate-errors" if ENV["TEST_SSL"] + Capybara::Selenium::Driver.new( + app, + browser: :chrome, + capabilities: [options] + ) +end \ No newline at end of file diff --git a/spec/system/account_spec.rb b/spec/system/account_spec.rb index 44ca322..32f653c 100644 --- a/spec/system/account_spec.rb +++ b/spec/system/account_spec.rb @@ -94,6 +94,7 @@ within ".title-bar" do expect(page).to have_content("Nikola Tesla") + expect(page).to have_content("Castellano") end end end From f2e62924de7a3e3d3eda06b80d058f9b6f005218 Mon Sep 17 00:00:00 2001 From: quentinchampenois <26109239+Quentinchampenois@users.noreply.github.com> Date: Mon, 4 Mar 2024 15:45:55 +0100 Subject: [PATCH 2/3] fix: Allow user to change default locale --- .../extra_user_fields/update_account_commands_overrides.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/app/commands/concerns/decidim/extra_user_fields/update_account_commands_overrides.rb b/app/commands/concerns/decidim/extra_user_fields/update_account_commands_overrides.rb index 2f0f081..2c43185 100644 --- a/app/commands/concerns/decidim/extra_user_fields/update_account_commands_overrides.rb +++ b/app/commands/concerns/decidim/extra_user_fields/update_account_commands_overrides.rb @@ -11,6 +11,7 @@ module UpdateAccountCommandsOverrides private def update_personal_data + @user.locale = @form.locale @user.name = @form.name @user.nickname = @form.nickname @user.email = @form.email From 2feb705eca7a4fa7875ac30c690999ec2849c7c2 Mon Sep 17 00:00:00 2001 From: quentinchampenois <26109239+Quentinchampenois@users.noreply.github.com> Date: Mon, 4 Mar 2024 15:46:13 +0100 Subject: [PATCH 3/3] lint: Fix rubocop offense --- spec/spec_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index fa1b4a9..66d395a 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -23,4 +23,4 @@ browser: :chrome, capabilities: [options] ) -end \ No newline at end of file +end