all linting passed!

Author: katzy687

.pre-commit-config.yaml

@@ -4,28 +4,28 @@ repos:
     hooks:
       - id: isort
         language_version: python3.7
-        args: [--line-length=127]
+        args: [ --line-length=127 ]
   - repo: https://github.com/python/black
     rev: 20.8b1
     hooks:
       - id: black
         language_version: python3.7
-        args: [--line-length=127]
+        args: [ --line-length=127 ]
   - repo: https://gitlab.com/pycqa/flake8
     rev: 3.8.3
     hooks:
       - id: flake8
         additional_dependencies: [
-          flake8-docstrings,
-          flake8-builtins,
-          flake8-comprehensions,
-          flake8-print,
-          flake8-eradicate,
+            flake8-docstrings,
+            flake8-builtins,
+            flake8-comprehensions,
+            flake8-print,
+            flake8-eradicate,
         ]
         language_version: python3.7
         args: [
-          --max-line-length=127,
-          '--ignore=D100,D101,D102,D103,D104,D105,D106,D107,D200,D210,D401,W503,E203'
+            --max-line-length=127,
+            '--ignore=D100,D101,D102,D103,D104,D105,D106,D107,D200,D205,D210,D400,D401,W503,E203,F403,F405,T001'
         ]
   # See https://stackoverflow.com/questions/61238318/pylint-and-pre-commit-hook-unable-to-import/61238571#61238571
   - repo: local
@@ -34,11 +34,11 @@ repos:
         name: pylint
         entry: pylint
         language: system
-        types: [python]
+        types: [ python ]
         args: [
-#          --max-line-length=127,
-#          --max-public-methods=32,
-#          --max-args=8,
-          '--disable=too-few-public-methods,logging-fstring-interpolation,too-many-instance-attributes,no-else-return,too-many-locals,no-self-use,duplicate-code,broad-except,logging-not-lazy,unspecified-encoding',
-          '--good-names=ip,rc,eval'
+            --max-line-length=127,
+            --max-public-methods=32,
+            --max-args=9,
+            '--disable=too-few-public-methods,logging-fstring-interpolation,too-many-instance-attributes,no-else-return,too-many-locals,no-self-use,duplicate-code,broad-except,logging-not-lazy,unspecified-encoding, unused-wildcard-import,missing-function-docstring,missing-module-docstring,import-error,wildcard-import,invalid-name,redefined-outer-name,no-name-in-module',
+            '--good-names=ip,rc,eval'
         ]

cloudshell/sandbox_rest/exceptions.py

@@ -2,22 +2,22 @@
 
 
 class SandboxRestException(Exception):
-    """Base Exception Class inside Rest client class"""
+    """ Base Exception Class inside Rest client class """
 
-    def __init__(self, msg: str, response: Response = None):
-        self.msg = msg
+    def __init__(self, message: str, response: Response = None):
+        super().__init__(message)
+        self.message = message
         self.response = response
 
     def __str__(self):
-        return self._format_err_msg(self.msg, self.response)
+        return self._format_err_msg(self.message, self.response)
 
-    def _format_err_msg(
-        self, custom_err_msg="Failed Api Call", response: Response = None
-    ) -> str:
+    def _format_err_msg(self, custom_err_msg="Failed Api Call", response: Response = None) -> str:
         err_msg = f"Sandbox API Error: {custom_err_msg}"
 
         if response:
             err_msg += f"\n{self._format_response_msg(response)}"
+        return err_msg
 
     @staticmethod
     def _format_response_msg(response: Response):
@@ -30,5 +30,3 @@ def _format_response_msg(response: Response):
 
 class SandboxRestAuthException(SandboxRestException):
     """Failed auth action"""
-
-    pass