Skip to content

Commit 61ca899

Browse files
committed
cleanup
1 parent c41464f commit 61ca899

File tree

4 files changed

+13
-33
lines changed

4 files changed

+13
-33
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
## Unreleased
22

33
* If cookies are disabled by user, then fallback to localstorage to save the cookie data.
4-
* Migrate sessionId, lastEventTime, eventId, and identifyId to cookie storage to support sessions across different subdomains.
4+
* Migrate sessionId, lastEventTime, eventId, identifyId, and sequenceNumber to cookie storage to support sessions across different subdomains.
55

66
## 2.6.2 (November 17, 2015)
77

amplitude.js

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -418,21 +418,11 @@ var _saveCookieData = function(scope) {
418418

419419
// the follow fields used to be saved in localStorage, now saved in cookie to support different subdomains
420420
var _clearSessionAndEventTrackingFromLocalStorage = function() {
421-
if (localStorage.getItem(LocalStorageKeys.SESSION_ID)) {
422-
localStorage.removeItem(LocalStorageKeys.SESSION_ID);
423-
}
424-
if (localStorage.getItem(LocalStorageKeys.LAST_EVENT_TIME)) {
425-
localStorage.removeItem(LocalStorageKeys.LAST_EVENT_TIME);
426-
}
427-
if (localStorage.getItem(LocalStorageKeys.LAST_EVENT_ID)) {
428-
localStorage.removeItem(LocalStorageKeys.LAST_EVENT_ID);
429-
}
430-
if (localStorage.getItem(LocalStorageKeys.LAST_IDENTIFY_ID)) {
431-
localStorage.removeItem(LocalStorageKeys.LAST_IDENTIFY_ID);
432-
}
433-
if (localStorage.getItem(LocalStorageKeys.LAST_SEQUENCE_NUMBER)) {
434-
localStorage.removeItem(LocalStorageKeys.LAST_SEQUENCE_NUMBER);
435-
}
421+
localStorage.removeItem(LocalStorageKeys.SESSION_ID);
422+
localStorage.removeItem(LocalStorageKeys.LAST_EVENT_TIME);
423+
localStorage.removeItem(LocalStorageKeys.LAST_EVENT_ID);
424+
localStorage.removeItem(LocalStorageKeys.LAST_IDENTIFY_ID);
425+
localStorage.removeItem(LocalStorageKeys.LAST_SEQUENCE_NUMBER);
436426
};
437427

438428
Amplitude._getUtmParam = function(name, query) {

amplitude.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/amplitude.js

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -312,21 +312,11 @@ var _saveCookieData = function(scope) {
312312

313313
// the follow fields used to be saved in localStorage, now saved in cookie to support different subdomains
314314
var _clearSessionAndEventTrackingFromLocalStorage = function() {
315-
if (localStorage.getItem(LocalStorageKeys.SESSION_ID)) {
316-
localStorage.removeItem(LocalStorageKeys.SESSION_ID);
317-
}
318-
if (localStorage.getItem(LocalStorageKeys.LAST_EVENT_TIME)) {
319-
localStorage.removeItem(LocalStorageKeys.LAST_EVENT_TIME);
320-
}
321-
if (localStorage.getItem(LocalStorageKeys.LAST_EVENT_ID)) {
322-
localStorage.removeItem(LocalStorageKeys.LAST_EVENT_ID);
323-
}
324-
if (localStorage.getItem(LocalStorageKeys.LAST_IDENTIFY_ID)) {
325-
localStorage.removeItem(LocalStorageKeys.LAST_IDENTIFY_ID);
326-
}
327-
if (localStorage.getItem(LocalStorageKeys.LAST_SEQUENCE_NUMBER)) {
328-
localStorage.removeItem(LocalStorageKeys.LAST_SEQUENCE_NUMBER);
329-
}
315+
localStorage.removeItem(LocalStorageKeys.SESSION_ID);
316+
localStorage.removeItem(LocalStorageKeys.LAST_EVENT_TIME);
317+
localStorage.removeItem(LocalStorageKeys.LAST_EVENT_ID);
318+
localStorage.removeItem(LocalStorageKeys.LAST_IDENTIFY_ID);
319+
localStorage.removeItem(LocalStorageKeys.LAST_SEQUENCE_NUMBER);
330320
};
331321

332322
Amplitude._getUtmParam = function(name, query) {

0 commit comments

Comments
 (0)