Skip to content

Commit 9b34c62

Browse files
committed
test: verify Puppeteer E2E infrastructure on Windows CI
Integrates `executeBrowserTest` into the `basic/serve` E2E test to verify browser connectivity against a running HMR server. Additionally, enables the `basic/serve` test in the Windows CI workflow to ensure Puppeteer infrastructure stability on Windows.
1 parent e9be53f commit 9b34c62

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

.github/workflows/pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ jobs:
170170
test_target_name: e2e.esbuild_node22
171171
env:
172172
E2E_SHARD_TOTAL: 1
173-
TESTBRIDGE_TEST_ONLY: tests/basic/{build,rebuild}.ts
173+
TESTBRIDGE_TEST_ONLY: tests/basic/{build,rebuild,serve}.ts
174174

175175
e2e-package-managers:
176176
needs: build

tests/e2e/tests/basic/serve.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import assert from 'node:assert/strict';
22
import { killAllProcesses } from '../../utils/process';
33
import { ngServe } from '../../utils/project';
4+
import { executeBrowserTest } from '../../utils/puppeteer';
45

56
export default async function () {
67
// Serve works without HMR
@@ -11,6 +12,8 @@ export default async function () {
1112
// Serve works with HMR
1213
const hmrPort = await ngServe('--hmr');
1314
await verifyResponse(hmrPort);
15+
16+
await executeBrowserTest({ baseUrl: `http://localhost:${hmrPort}/` });
1417
}
1518

1619
async function verifyResponse(port: number): Promise<void> {

0 commit comments

Comments
 (0)