Fixed linter warnings

commands/service_compile.go:356:4: QF1012: Use fmt.Fprintf(...) instead of Write([]byte(fmt.Sprintf(...))) (staticcheck)
                        outStream.Write([]byte(fmt.Sprintf("Could not normalize FQBN: %s\n", err)))
                        ^
commands/service_compile.go:359:3: QF1012: Use fmt.Fprintf(...) instead of Write([]byte(fmt.Sprintf(...))) (staticcheck)
                outStream.Write([]byte(fmt.Sprintf("FQBN: %s\n", normalizedFQBN)))
                ^
commands/service_upload.go:508:4: QF1012: Use fmt.Fprintln(...) instead of Write([]byte(fmt.Sprintln(...))) (staticcheck)
                        outStream.Write([]byte(fmt.Sprintln(i18n.Tr("Skipping 1200-bps touch reset: no serial port selected!"))))
                        ^
commands/service_upload.go:515:6: QF1012: Use fmt.Fprintln(...) instead of Write([]byte(fmt.Sprintln(...))) (staticcheck)
                                        outStream.Write([]byte(fmt.Sprintln(i18n.Tr("Performing 1200-bps touch reset on serial port %s", portAddress))))
                                        ^
commands/service_upload.go:521:6: QF1012: Use fmt.Fprintln(...) instead of Write([]byte(fmt.Sprintln(...))) (staticcheck)
                                        outStream.Write([]byte(fmt.Sprintln(i18n.Tr("Waiting for upload port..."))))
                                        ^
internal/arduino/builder/internal/preprocessor/ctags.go:68:3: QF1012: Use fmt.Fprintf(...) instead of WriteString(fmt.Sprintf(...)) (staticcheck)
                stderr.WriteString(fmt.Sprintf("%s: %s",
                ^
internal/mock_serial_monitor/main.go:146:4: QF1012: Use fmt.Fprintf(...) instead of Write([]byte(fmt.Sprintf(...))) (staticcheck)
                        d.mockedSerialPort.Write([]byte(
                        ^

Author: cmaglie

commands/service_compile.go

@@ -353,10 +353,10 @@ func (s *arduinoCoreServerImpl) Compile(req *rpc.CompileRequest, stream rpc.Ardu
 		// select the core name in case of "package:core" format
 		normalizedFQBN, err := pme.NormalizeFQBN(fqbn)
 		if err != nil {
-			outStream.Write([]byte(fmt.Sprintf("Could not normalize FQBN: %s\n", err)))
+			fmt.Fprintf(outStream, "Could not normalize FQBN: %s\n", err)
 			normalizedFQBN = fqbn
 		}
-		outStream.Write([]byte(fmt.Sprintf("FQBN: %s\n", normalizedFQBN)))
+		fmt.Fprintf(outStream, "FQBN: %s\n", normalizedFQBN)
 		core = core[strings.Index(core, ":")+1:]
 		outStream.Write([]byte(i18n.Tr("Using board '%[1]s' from platform in folder: %[2]s", targetBoard.BoardID, targetPlatform.InstallDir) + "\n"))
 		outStream.Write([]byte(i18n.Tr("Using core '%[1]s' from platform in folder: %[2]s", core, buildPlatform.InstallDir) + "\n"))

commands/service_upload.go

@@ -505,20 +505,20 @@ func (s *arduinoCoreServerImpl) runProgramAction(ctx context.Context, pme *packa
 
 		// if touch is requested but port is not specified, print a warning
 		if touch && portToTouch == "" {
-			outStream.Write([]byte(fmt.Sprintln(i18n.Tr("Skipping 1200-bps touch reset: no serial port selected!"))))
+			fmt.Fprintln(outStream, i18n.Tr("Skipping 1200-bps touch reset: no serial port selected!"))
 		}
 
 		cb := &serialutils.ResetProgressCallbacks{
 			TouchingPort: func(portAddress string) {
 				logrus.WithField("phase", "board reset").Infof("Performing 1200-bps touch reset on serial port %s", portAddress)
 				if verbose {
-					outStream.Write([]byte(fmt.Sprintln(i18n.Tr("Performing 1200-bps touch reset on serial port %s", portAddress))))
+					fmt.Fprintln(outStream, i18n.Tr("Performing 1200-bps touch reset on serial port %s", portAddress))
 				}
 			},
 			WaitingForNewSerial: func() {
 				logrus.WithField("phase", "board reset").Info("Waiting for upload port...")
 				if verbose {
-					outStream.Write([]byte(fmt.Sprintln(i18n.Tr("Waiting for upload port..."))))
+					fmt.Fprintln(outStream, i18n.Tr("Waiting for upload port..."))
 				}
 			},
 			BootloaderPortFound: func(portAddress string) {

internal/arduino/builder/internal/preprocessor/ctags.go

@@ -65,9 +65,9 @@ func PreprocessSketchWithCtags(
 		}
 
 		// Do not bail out if we are generating the compile commands database
-		stderr.WriteString(fmt.Sprintf("%s: %s",
+		fmt.Fprintf(stderr, "%s: %s",
 			i18n.Tr("An error occurred adding prototypes"),
-			i18n.Tr("the compilation database may be incomplete or inaccurate")))
+			i18n.Tr("the compilation database may be incomplete or inaccurate"))
 		if err := sourceFile.CopyTo(ctagsTarget); err != nil {
 			return &Result{args: result.Args(), stdout: stdout.Bytes(), stderr: stderr.Bytes()}, err
 		}

internal/mock_serial_monitor/main.go

@@ -143,8 +143,7 @@ func (d *SerialMonitor) Open(boardPort string) (io.ReadWriter, error) {
 			d.mockedSerialPort.Write([]byte("Tmpfile: " + d.muxFile.String() + "\n"))
 		}
 		for parameter, descriptor := range d.serialSettings.ConfigurationParameter {
-			d.mockedSerialPort.Write([]byte(
-				fmt.Sprintf("Configuration %s = %s\n", parameter, descriptor.Selected)))
+			fmt.Fprintf(d.mockedSerialPort, "Configuration %s = %s\n", parameter, descriptor.Selected)
 		}
 		for {
 			n, err := d.mockedSerialPort.Read(buff)