Rename methods

Author: morten.lund@maskon.no

lib/partitioning.ex

@@ -27,11 +27,25 @@ defmodule AshPostgres.Partitioning do
   @doc """
   Check if partition exists
   """
-  def exists?(resource, opts) do
+  def existing_partition?(resource, opts) do
     repo = AshPostgres.DataLayer.Info.repo(resource)
-    partition_name = partition_name(resource, opts)
 
-    partition_exists?(repo, resource, partition_name, opts)
+    resource
+    |> AshPostgres.DataLayer.Info.partitioning_method()
+    |> case do
+      :range ->
+        false
+
+      :list ->
+        partition_name = partition_name(resource, opts)
+        schema_exists?(repo, resource, partition_name, opts)
+
+      :hash ->
+        false
+
+      unsupported_method ->
+        raise "Invalid partition method, got: #{unsupported_method}"
+    end
   end
 
   # TBI
@@ -47,15 +61,15 @@ defmodule AshPostgres.Partitioning do
       Keyword.get(opts, :tenant)
       |> tenant_schema(resource)
 
-    if partition_exists?(repo, resource, partition_name, opts) do
+    if schema_exists?(repo, resource, partition_name, opts) do
       {:error, :already_exists}
     else
       Ecto.Adapters.SQL.query(
         repo,
         "CREATE TABLE \"#{schema}\".\"#{partition_name}\" PARTITION OF \"#{schema}\".\"#{table}\" FOR VALUES IN ('#{key}')"
       )
 
-      if partition_exists?(repo, resource, partition_name, opts) do
+      if schema_exists?(repo, resource, partition_name, opts) do
         :ok
       else
         {:error, "Unable to create partition"}
@@ -67,7 +81,7 @@ defmodule AshPostgres.Partitioning do
   defp create_hash_partition(_repo, _resource, _opts) do
   end
 
-  defp partition_exists?(repo, resource, parition_name, opts) do
+  defp schema_exists?(repo, resource, parition_name, opts) do
     schema =
       Keyword.get(opts, :tenant)
       |> tenant_schema(resource)

test/partition_test.exs

@@ -3,9 +3,9 @@ defmodule AshPostgres.PartitionTest do
   alias AshPostgres.Test.PartitionedPost
 
   test "seeding data works" do
-    assert false == AshPostgres.Partitioning.exists?(PartitionedPost, key: 1)
+    assert false == AshPostgres.Partitioning.existing_partition?(PartitionedPost, key: 1)
     assert :ok == AshPostgres.Partitioning.create_partition(PartitionedPost, key: 1)
-    assert true == AshPostgres.Partitioning.exists?(PartitionedPost, key: 1)
+    assert true == AshPostgres.Partitioning.existing_partition?(PartitionedPost, key: 1)
 
     Ash.Seed.seed!(%PartitionedPost{key: 1})