Validate value object required fields in the constructor (#1488)

* Refactor the code generating object properties

* Refactor the generation of array getters

Optional array fields still need to consider the property as nullable
even though the getter will return an empty array as AWS does not treat
absent lists the same than empty lists in input.

* Add validation of required parameters in value object constructors

* Remove checks for missing properties for value object request bodies

This is already validated in the constructor now.

Author: stof

src/ValueObject/EphemeralStorage.php

@@ -2,6 +2,8 @@
 
 namespace AsyncAws\Lambda\ValueObject;
 
+use AsyncAws\Core\Exception\InvalidArgument;
+
 /**
  * The size of the function's `/tmp` directory in MB. The default value is 512, but it can be any whole number between
  * 512 and 10,240 MB.
@@ -20,7 +22,7 @@ final class EphemeralStorage
      */
     public function __construct(array $input)
     {
-        $this->size = $input['Size'] ?? null;
+        $this->size = $input['Size'] ?? $this->throwException(new InvalidArgument('Missing required field "Size".'));
     }
 
     /**
@@ -37,4 +39,12 @@ public function getSize(): int
     {
         return $this->size;
     }
+
+    /**
+     * @return never
+     */
+    private function throwException(\Throwable $exception)
+    {
+        throw $exception;
+    }
 }

src/ValueObject/FileSystemConfig.php

@@ -2,6 +2,8 @@
 
 namespace AsyncAws\Lambda\ValueObject;
 
+use AsyncAws\Core\Exception\InvalidArgument;
+
 /**
  * Details about the connection between a Lambda function and an Amazon EFS file system [^1].
  *
@@ -27,8 +29,8 @@ final class FileSystemConfig
      */
     public function __construct(array $input)
     {
-        $this->arn = $input['Arn'] ?? null;
-        $this->localMountPath = $input['LocalMountPath'] ?? null;
+        $this->arn = $input['Arn'] ?? $this->throwException(new InvalidArgument('Missing required field "Arn".'));
+        $this->localMountPath = $input['LocalMountPath'] ?? $this->throwException(new InvalidArgument('Missing required field "LocalMountPath".'));
     }
 
     /**
@@ -51,4 +53,12 @@ public function getLocalMountPath(): string
     {
         return $this->localMountPath;
     }
+
+    /**
+     * @return never
+     */
+    private function throwException(\Throwable $exception)
+    {
+        throw $exception;
+    }
 }