Skip to content

BBC: Bleadperl v5.41.4 breaks Graphics-Raylib-0.025 (due pp_pack: SvPV_force()...) #5

@andk

Description

@andk

Fail report: http://www.cpantesters.org/cpan/report/041be644-7c7f-11ef-94fa-40dcd30fa6a7

Bisect points to:

3d831e8998dab40881aa457d1027c4f0fe1ef3d2 is the first bad commit
commit 3d831e8998dab40881aa457d1027c4f0fe1ef3d2
Author: Tony Cook <tony@develop-help.com>
Date:   Mon Jul 15 11:45:16 2024 +1000

    pp_pack: SvPV_force() pack(p/P, ...) arguments when writable

    pack("p"/"P") is generally pretty awful, but we document that you
    can pack("P") and then write to the pointer supplied, so make that
    safer by ensuring the PV isn't shared with other SVs.

    Since _force() throws on a READONLY SV, and you shouldn't be writing
    to one, only _force() for a writable SV.

    This is still broken when magic is involved, but we did document it
    as usable.

    Fixes the UUID::FFI part of #22380

    Some other modules (and UUID::FFI itself, really) will need XS
    fixes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions