move metadata constant to constant file

Author: SagarGaniga

bin/helpers/constants.js

@@ -135,7 +135,8 @@ const specFileTypes = ['js', 'ts', 'feature', 'jsx', 'coffee', 'cjsx'];
 
 const DEFAULT_CYPRESS_SPEC_PATH = "cypress/integration"
 
-const SPEC_TOTAL_CHAR_LIMIT = 32243
+const SPEC_TOTAL_CHAR_LIMIT = 32243;
+const METADATA_CHAR_BUFFER_PER_SPEC = 175;
 
 module.exports = Object.freeze({
   syncCLI,
@@ -147,5 +148,6 @@ module.exports = Object.freeze({
   filesToIgnoreWhileUploading,
   specFileTypes,
   DEFAULT_CYPRESS_SPEC_PATH,
-  SPEC_TOTAL_CHAR_LIMIT
+  SPEC_TOTAL_CHAR_LIMIT,
+  METADATA_CHAR_BUFFER_PER_SPEC
 });

bin/helpers/utils.js

@@ -149,11 +149,11 @@ exports.setParallels = (bsConfig, args, numOfSpecs) => {
 };
 
 exports.warnSpecLimit = (bsConfig, args, specFiles) => {
-  let expectedCharLength = specFiles.join("").length + 175 * specFiles.length;
-  let parallels = bsConfig['run_settings']['parallels'];
+  let expectedCharLength = specFiles.join("").length + Constants.METADATA_CHAR_BUFFER_PER_SPEC * specFiles.length;
+  let parallels = bsConfig.run_settings.parallels;
   let combinations = this.getBrowserCombinations(bsConfig).length;
-  let parallelPerCombination = parallels > combinations ? Math.floor(parallels / combinations) : 1
-  let expectedCharLengthPerParallel = expectedCharLength / parallelPerCombination
+  let parallelPerCombination = parallels > combinations ? Math.floor(parallels / combinations) : 1;
+  let expectedCharLengthPerParallel = Math.floor(expectedCharLength / parallelPerCombination);
   if (expectedCharLengthPerParallel > Constants.SPEC_TOTAL_CHAR_LIMIT) {
     logger.warn(Constants.userMessages.SPEC_LIMIT_WARNING);
     this.sendUsageReport(