fix test cases and handle some edge cases

Author: SagarGaniga

bin/helpers/sync/syncSpecsLogs.js

@@ -119,10 +119,7 @@ let showSpecsStatus = (data) => {
     if (specDetails == "created") {
       printInitialLog();
     } else {
-      try {
-        printSpecData(JSON.parse(specDetails))
-      } catch (error) {
-      }
+      printSpecData(JSON.parse(specDetails))
     }
   });
 }

test/unit/bin/commands/runs.js

@@ -517,7 +517,7 @@ describe("runs", () => {
       let messageType = Constants.messageTypes.SUCCESS;
       let errorCode = null;
       let message = `Success! ${Constants.userMessages.BUILD_CREATED} with build id: random_build_id`;
-      let dashboardLink = `${Constants.userMessages.VISIT_DASHBOARD} ${dashboardUrl}random_build_id`;
+      let dashboardLink = `${Constants.userMessages.VISIT_DASHBOARD} ${dashboardUrl}`;
 
       const runs = proxyquire("../../../../bin/commands/runs", {
         "../helpers/utils": {
@@ -564,7 +564,7 @@ describe("runs", () => {
       );
       archiverStub.returns(Promise.resolve("Zipping completed"));
       zipUploadStub.returns(Promise.resolve("zip uploaded"));
-      createBuildStub.returns(Promise.resolve({ message: 'Success', build_id: 'random_build_id' }));
+      createBuildStub.returns(Promise.resolve({ message: 'Success', build_id: 'random_build_id', dashboard_url: dashboardUrl }));
 
       return runs(args)
         .then(function (_bsConfig) {

test/unit/bin/helpers/sync/failedSpecDetails.js

@@ -3,10 +3,23 @@ const chai = require("chai"),
   expect = chai.expect,
   chaiAsPromised = require("chai-as-promised");
 
+const sinon = require("sinon");
 chai.use(chaiAsPromised);
 const specDetails = require('../../../../../bin/helpers/sync/failedSpecsDetails');
+var logger = require("../../../../../bin/helpers/logger").syncCliLogger;
 
 describe("failedSpecsDetails", () => {
+  var sandbox;
+
+  beforeEach(() => {
+    sandbox = sinon.createSandbox();
+    sandbox.stub(logger, 'info');
+  });
+
+  afterEach(() => {
+    sandbox.restore();
+  });
+
   context("data is empty", () => {
     let data = [];
     it('returns 0 exit code', () => {
@@ -30,7 +43,8 @@ describe("failedSpecsDetails", () => {
 
   context("data has failed specs", () => {
     let data = [
-      {specName: 'spec2.name.js', status: 'Failed', combination: 'Win 10 / Chrome 78', sessionId: '3d3rdf3r...'}
+      {specName: 'spec2.name.js', status: 'Failed', combination: 'Win 10 / Chrome 78', sessionId: '3d3rdf3r...'},
+      {specName: 'spec2.name.js', status: 'Passed', combination: 'Win 10 / Chrome 78', sessionId: '3d3rdf3r...'}
     ];
 
     it("returns 1 exit code", () => {

test/unit/bin/helpers/sync/syncSpecsLogs.js

@@ -7,7 +7,6 @@ const chai = require("chai"),
   request = require("request");
 
 const sinon = require("sinon");
-// var sandbox = require('sinon').createSandbox();
 
 chai.use(chaiAsPromised);
 

test/unit/bin/helpers/utils.js

@@ -140,15 +140,19 @@ describe("utils", () => {
   describe("validateBstackJson", () => {
     it("should reject with SyntaxError for empty file", () => {
       let bsConfigPath = path.join(process.cwd(), 'test', 'test_files', 'dummy_bstack.json');
-      expect(utils.validateBstackJson(bsConfigPath)).to.be.rejectedWith(SyntaxError);
+      return utils.validateBstackJson(bsConfigPath).catch((error)=>{
+        sinon.match(error, "Invalid browserstack.json file")
+      });
     });
     it("should resolve with data for valid json", () => {
       let bsConfigPath = path.join(process.cwd(), 'test', 'test_files', 'dummy_bstack_2.json');
       expect(utils.validateBstackJson(bsConfigPath)).to.be.eventually.eql({});
     });
     it("should reject with SyntaxError for invalid json file", () => {
       let bsConfigPath = path.join(process.cwd(), 'test', 'test_files', 'dummy_bstack_3.json');
-      expect(utils.validateBstackJson(bsConfigPath)).to.be.rejectedWith(SyntaxError);
+      return utils.validateBstackJson(bsConfigPath).catch((error) => {
+        sinon.match(error, "Invalid browserstack.json file")
+      });
     });
   });