Resolve comment and remove local spawning code

Author: nagpalkaran95

bin/commands/runs.js

@@ -149,20 +149,29 @@ module.exports = function run(args, rawArgs) {
       }
 
       if (turboScaleSession) {
+        // Local is only required in case user is running on trial grid and wants to access private website.
+        // Even then, it will be spawned separately via browserstack-cli ats connect-grid command and not via browserstack-cypress-cli
+        // Hence whenever running on ATS, need to make local as false
+        bsConfig.connection_settings.local = false;
+
         const gridDetails = await getTurboScaleGridDetails(bsConfig);
-        Constants.turboScaleObj.gridDetails = gridDetails;
 
-        if (gridDetails.isTrialGrid) {
-          bsConfig.connection_settings.local = true;
-          bsConfig.connection_settings.local_inferred = true;
-          bsConfig.connection_settings.local_mode = 'on-demand';
-        }
+        if (gridDetails && Object.keys(gridDetails).length > 0) {
+          Constants.turboScaleObj.gridDetails = gridDetails;
+
+          if (gridDetails.isTrialGrid) {
+            logger.info('Will be running the build on Trial Grid. Ensure you are using connect-grid command if using a private website');
+          }
 
-        Constants.turboScaleObj.gridUrl = gridDetails.cypressUrl;
-        Constants.turboScaleObj.uploadUrl = gridDetails.cypressUrl + '/upload';
-        Constants.turboScaleObj.buildUrl = gridDetails.cypressUrl + '/build';
+          Constants.turboScaleObj.gridUrl = gridDetails.cypressUrl;
+          Constants.turboScaleObj.uploadUrl = gridDetails.cypressUrl + '/upload';
+          Constants.turboScaleObj.buildUrl = gridDetails.cypressUrl + '/build';
 
-        logger.debug(`Automate TurboScale Grid URL set to ${gridDetails.url}`);
+          logger.debug(`Automate TurboScale Grid URL set to ${gridDetails.url}`);
+        } else {
+          process.exitCode = Constants.ERROR_EXIT_CODE;
+          return;
+        }
       }
     }
 

bin/helpers/atsHelper.js

@@ -66,7 +66,7 @@ exports.getTurboScaleGridDetails = async (bsConfig) => {
             responseData = {};
           }
           if(resp.statusCode != 200) {
-            logger.warn(`Warn: Get Initial Details Request failed with status code ${resp.statusCode}`);
+            logger.warn(`Warn: Get Automate TurboScale Details Request failed with status code ${resp.statusCode}`);
             utils.sendUsageReport(bsConfig, args, responseData["error"], Constants.messageTypes.ERROR, 'get_ats_details_failed', null, rawArgs);
             resolve({});
           }

bin/helpers/utils.js

@@ -971,12 +971,6 @@ exports.setLocalArgs = (bsConfig, args) => {
   if (bsConfig["connection_settings"]["useCaCertificate"])
     local_args['useCaCertificate'] = bsConfig["connection_settings"]["useCaCertificate"];
 
-  if (Constants.turboScaleObj.enabled) {
-    local_args['forceLocal'] = true;
-    local_args['localIdentifier'] = 'ats-repeater';
-    local_args['custom-repeater'] = Constants.turboScaleObj.gridDetails.customRepeaters.join(',');
-  }
-
   local_args['daemon'] = true;
   local_args['enable-logging-for-api'] = true
   local_args['source'] = `cypress:${usageReporting.cli_version_and_path(bsConfig).version}`;