diff --git a/src/controllers/member.controller.ts b/src/controllers/member.controller.ts index c89ff64..525854f 100644 --- a/src/controllers/member.controller.ts +++ b/src/controllers/member.controller.ts @@ -74,7 +74,7 @@ export const updateAMember = (supabase: SupabaseClient) => async (req: Request, res: Response) => { const { memberId } = req.params; - + if(!memberId) throw new ApiError("No memberId provided", 400); const parsedBody = JSON.parse(req.body.memberData); @@ -84,7 +84,7 @@ export const updateAMember = const oldData = await memberService.getDetails(memberId); const oldImage = oldData?.profilePhoto; - if(oldImage) await uploadImage(supabase, req.file, "members", oldImage); + if(oldImage) imageUrl = await uploadImage(supabase, req.file, "members", oldImage); else imageUrl = await uploadImage(supabase, req.file, "members"); } if (imageUrl) parsedBody.profilePhoto = imageUrl; @@ -155,4 +155,4 @@ export const getUserInterviews = async (req: Request, res: Response) => { const interviews = await memberService.getInterviews(memberId); res.status(200).json({ success: true, interviews }); -}; \ No newline at end of file +}; diff --git a/tests/Member.test.ts b/tests/Member.test.ts index 9774144..d80f545 100644 --- a/tests/Member.test.ts +++ b/tests/Member.test.ts @@ -180,8 +180,10 @@ describe('Member Controller - updateAMember', () => { ); expect(memberService.updateMember).toHaveBeenCalledWith('abc-123', { + profilePhoto: 'https://new.url/image.png', }); + expect(res.status).toHaveBeenCalledWith(200); expect(res.json).toHaveBeenCalledWith({ success: true,