Skip to content

Makefile isn't sourced from workspace root, but from current source file's directory #43

@NickVanderPyle

Description

@NickVanderPyle

When setting DASM default compiler to Make, the extension's action to compile the source code can't find my Makefile if it's in a parent directory. Can the extension reference the root workspace directory or walk the parent directories to workspace root until it finds a Makefile?

It appears that GetWorkspace uses the current source file's directory rather than the workspace root directory which causes FindTerminalMakeFileAsync to not consider VSCode's workspace root when looking for a Makefile.

I have a project where the Makefile is in the root, but the source files are in a subdirectory.

/
  /include
  /out
  /src
    project.asm
  Makefile

This isn't a breaking problem since the Makefile can be run from terminal, but the extension's behavior was unexpected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions