From ee884eda6f380cfb70e03539d3c1f05271c3744a Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Thu, 14 Nov 2024 22:01:34 -0500 Subject: [PATCH 01/15] fix: do tokenless --- .github/workflows/ci.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5e42465a..e91f0a44 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,8 +17,6 @@ jobs: - name: Run tests and collect coverage run: pytest --cov app ${{ env.CODECOV_ATS_TESTS }} - name: Upload coverage to Codecov - uses: codecov/codecov-action@v4 + uses: codecov/codecov-action@7ff8c66a50230f45e5ce25141ac0169d09344819 with: verbose: true - env: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} From 4c62b86045a5a017371ce66ed0d60627af65afb8 Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Thu, 14 Nov 2024 22:01:54 -0500 Subject: [PATCH 02/15] fix: should fail --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e91f0a44..310c6701 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,6 +17,7 @@ jobs: - name: Run tests and collect coverage run: pytest --cov app ${{ env.CODECOV_ATS_TESTS }} - name: Upload coverage to Codecov - uses: codecov/codecov-action@7ff8c66a50230f45e5ce25141ac0169d09344819 + # uses: codecov/codecov-action@7ff8c66a50230f45e5ce25141ac0169d09344819 + uses: codecov/codecov-action@v5 with: verbose: true From c54e6a26ae414fc50ea720a5916473ed104e1b5c Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Thu, 14 Nov 2024 22:03:13 -0500 Subject: [PATCH 03/15] fix: it shoudl work now --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 310c6701..f38d05c5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,8 @@ jobs: - name: Run tests and collect coverage run: pytest --cov app ${{ env.CODECOV_ATS_TESTS }} - name: Upload coverage to Codecov - # uses: codecov/codecov-action@7ff8c66a50230f45e5ce25141ac0169d09344819 - uses: codecov/codecov-action@v5 + uses: codecov/codecov-action@7ff8c66a50230f45e5ce25141ac0169d09344819 + # uses: codecov/codecov-action@v5 with: + fail_ci_if_error: true verbose: true From 7a91ff392641b7cef519b1fae2cc5736769b1ee7 Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Thu, 14 Nov 2024 22:07:05 -0500 Subject: [PATCH 04/15] fix: use the new sha --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f38d05c5..aa9128f7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: - name: Run tests and collect coverage run: pytest --cov app ${{ env.CODECOV_ATS_TESTS }} - name: Upload coverage to Codecov - uses: codecov/codecov-action@7ff8c66a50230f45e5ce25141ac0169d09344819 + uses: codecov/codecov-action@453bbab47995460b3d7c6b3228c6757ab641f180 # uses: codecov/codecov-action@v5 with: fail_ci_if_error: true From 648a96449940392b18a9b03a876d1aca49fbe945 Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Thu, 14 Nov 2024 22:19:53 -0500 Subject: [PATCH 05/15] fix: it works on action repo --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index aa9128f7..9e756bc5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: - name: Run tests and collect coverage run: pytest --cov app ${{ env.CODECOV_ATS_TESTS }} - name: Upload coverage to Codecov - uses: codecov/codecov-action@453bbab47995460b3d7c6b3228c6757ab641f180 + uses: codecov/codecov-action@9301ab051930cc01e6bb8653208e56246571ee32 # uses: codecov/codecov-action@v5 with: fail_ci_if_error: true From 344e845d39a907caeb2dd27f73cdf46d9344c79d Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Thu, 14 Nov 2024 22:22:48 -0500 Subject: [PATCH 06/15] fix: just set to my branch --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9e756bc5..fa4d8ce2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: - name: Run tests and collect coverage run: pytest --cov app ${{ env.CODECOV_ATS_TESTS }} - name: Upload coverage to Codecov - uses: codecov/codecov-action@9301ab051930cc01e6bb8653208e56246571ee32 + uses: codecov/codecov-action@th/fix-tokenless-branches # uses: codecov/codecov-action@v5 with: fail_ci_if_error: true From aeed87613fb936fd7c8cf43cb515dd80bd4cc686 Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Thu, 14 Nov 2024 22:26:20 -0500 Subject: [PATCH 07/15] fix: check fake branch --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fa4d8ce2..72ffd60b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,3 +22,4 @@ jobs: with: fail_ci_if_error: true verbose: true + override_branch: fakebranch From aaffeb44106a8ebe2937479b3241c501bbe4ab3c Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Thu, 14 Nov 2024 22:31:49 -0500 Subject: [PATCH 08/15] fix: add env to see it fail --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 72ffd60b..eaa5897f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,8 +18,7 @@ jobs: run: pytest --cov app ${{ env.CODECOV_ATS_TESTS }} - name: Upload coverage to Codecov uses: codecov/codecov-action@th/fix-tokenless-branches - # uses: codecov/codecov-action@v5 with: fail_ci_if_error: true verbose: true - override_branch: fakebranch + env: OS,PYTHON From 114b5cca99f8357b2da29c1203e8cc60fed7f722 Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Thu, 14 Nov 2024 22:44:20 -0500 Subject: [PATCH 09/15] fix: one last shot --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index eaa5897f..ae74f447 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,4 +21,3 @@ jobs: with: fail_ci_if_error: true verbose: true - env: OS,PYTHON From b10716491524a071f0a8de6844b623391cd24e2c Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Fri, 15 Nov 2024 09:55:48 -0500 Subject: [PATCH 10/15] fix: test new thing --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ae74f447..8b3b93e4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: - name: Run tests and collect coverage run: pytest --cov app ${{ env.CODECOV_ATS_TESTS }} - name: Upload coverage to Codecov - uses: codecov/codecov-action@th/fix-tokenless-branches + uses: codecov/codecov-action@th/fix-pr-and-commit-fixes with: fail_ci_if_error: true verbose: true From 4b81c0ff94ae146b13a844be262d02e89496c41b Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Fri, 15 Nov 2024 10:05:03 -0500 Subject: [PATCH 11/15] fix: try again --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8b3b93e4..89110102 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,6 +16,7 @@ jobs: run: pip install -r requirements.txt - name: Run tests and collect coverage run: pytest --cov app ${{ env.CODECOV_ATS_TESTS }} + - name: Upload coverage to Codecov uses: codecov/codecov-action@th/fix-pr-and-commit-fixes with: From a4257fbdd0ac85fdee314d3a863428572329b956 Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Fri, 15 Nov 2024 10:10:15 -0500 Subject: [PATCH 12/15] fix: more things --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 89110102..2b24fbbf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,5 +1,5 @@ name: Workflow for Codecov example-python -on: [push, pull_request] +on: [push, pull_request, pull_request_target] jobs: run: runs-on: ubuntu-latest From 259877ed42e58807eed61809b79b03fbf0ca348b Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Fri, 15 Nov 2024 10:23:19 -0500 Subject: [PATCH 13/15] fix: run one more time --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2b24fbbf..0bf8e6b9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,6 @@ jobs: run: pip install -r requirements.txt - name: Run tests and collect coverage run: pytest --cov app ${{ env.CODECOV_ATS_TESTS }} - - name: Upload coverage to Codecov uses: codecov/codecov-action@th/fix-pr-and-commit-fixes with: From 982372b15d82b837af32de1e3bf6737bfa4ccda0 Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Tue, 19 Nov 2024 14:32:32 -0500 Subject: [PATCH 14/15] fix: use oidc --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0bf8e6b9..37c443b4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,9 +15,10 @@ jobs: - name: Install dependencies run: pip install -r requirements.txt - name: Run tests and collect coverage - run: pytest --cov app ${{ env.CODECOV_ATS_TESTS }} + run: pytest --cov app - name: Upload coverage to Codecov - uses: codecov/codecov-action@th/fix-pr-and-commit-fixes + uses: codecov/codecov-action@th/do-not-merge with: fail_ci_if_error: true verbose: true + use_oidc: true From a0680d6622fab89712923258e6a13ad89bffa7d3 Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Tue, 19 Nov 2024 14:58:51 -0500 Subject: [PATCH 15/15] fix: use main --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 37c443b4..4347a9a5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: - name: Run tests and collect coverage run: pytest --cov app - name: Upload coverage to Codecov - uses: codecov/codecov-action@th/do-not-merge + uses: codecov/codecov-action@main with: fail_ci_if_error: true verbose: true