refactor: text progress indicator can be replaced by an actual logger

Author: fioan89

src/main/kotlin/com/coder/toolbox/cli/CoderCLIManager.kt

@@ -60,7 +60,6 @@ fun ensureCLI(
     deploymentURL: URL,
     buildVersion: String,
     settings: CoderSettings,
-    indicator: ((t: String) -> Unit)? = null,
 ): CoderCLIManager {
     val cli = CoderCLIManager(deploymentURL, context.logger, settings)
 
@@ -76,7 +75,7 @@ fun ensureCLI(
 
     // If downloads are enabled download the new version.
     if (settings.enableDownloads) {
-        indicator?.invoke("Downloading Coder CLI...")
+        context.logger.info("Downloading Coder CLI...")
         try {
             cli.download()
             return cli
@@ -98,7 +97,7 @@ fun ensureCLI(
     }
 
     if (settings.enableDownloads) {
-        indicator?.invoke("Downloading Coder CLI...")
+        context.logger.info("Downloading Coder CLI...")
         dataCLI.download()
         return dataCLI
     }

src/main/kotlin/com/coder/toolbox/util/CoderProtocolHandler.kt

@@ -33,10 +33,7 @@ open class CoderProtocolHandler(
      * Throw if required arguments are not supplied or the workspace is not in a
      * connectable state.
      */
-    suspend fun handle(
-        parameters: Map<String, String>,
-        indicator: ((t: String) -> Unit)? = null,
-    ) {
+    suspend fun handle(parameters: Map<String, String>) {
         val deploymentURL =
             parameters.url() ?: dialogUi.ask(
                 context.i18n.ptrl("Deployment URL"),
@@ -121,17 +118,16 @@ open class CoderProtocolHandler(
                 context,
                 deploymentURL.toURL(),
                 client.buildInfo().version,
-                settings,
-                indicator,
+                settings
             )
 
         // We only need to log in if we are using token-based auth.
         if (client.token != null) {
-            indicator?.invoke("Authenticating Coder CLI...")
+            context.logger.info("Authenticating Coder CLI...")
             cli.login(client.token)
         }
 
-        indicator?.invoke("Configuring Coder CLI...")
+        context.logger.info("Configuring Coder CLI...")
         cli.configSsh(client.agentNames(workspaces))
 
         isInitialized.waitForTrue()

src/main/kotlin/com/coder/toolbox/views/ConnectPage.kt

@@ -101,9 +101,7 @@ class ConnectPage(
                 )
                 client.authenticate()
                 updateStatus(context.i18n.ptrl("Checking Coder binary..."), error = null)
-                val cli = ensureCLI(context, client.url, client.buildVersion, settings) { status ->
-                    updateStatus(context.i18n.pnotr(status), error = null)
-                }
+                val cli = ensureCLI(context, client.url, client.buildVersion, settings)
                 // We only need to log in if we are using token-based auth.
                 if (client.token != null) {
                     updateStatus(context.i18n.ptrl("Configuring CLI..."), error = null)