impl: show ssh network metrics in the Settings tab (2)

Discarded the download/upload stats, changed the text status, and I've
added support for Coder Connect.
UTs covering the status generation were also added.

Author: fioan89

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Added
+
+- render network status in the Settings tab, under `Additional environment information` section.
+
 ## 0.2.1 - 2025-05-05
 
 ### Changed

src/main/kotlin/com/coder/toolbox/CoderRemoteEnvironment.kt

@@ -180,7 +180,7 @@ class CoderRemoteEnvironment(
                     return@launch
                 }
                 context.logger.debug("$id metrics: $metrics")
-                additionalEnvironmentInformation.put(context.i18n.ptrl("Network Metrics"), metrics.toPretty())
+                additionalEnvironmentInformation.put(context.i18n.ptrl("Network Status"), metrics.toPretty())
             } catch (e: Exception) {
                 context.logger.error(
                     e,

src/main/kotlin/com/coder/toolbox/sdk/v2/models/NetworkMetrics.kt

@@ -2,6 +2,9 @@ package com.coder.toolbox.sdk.v2.models
 
 import com.squareup.moshi.Json
 import com.squareup.moshi.JsonClass
+import java.text.DecimalFormat
+
+private val formatter = DecimalFormat("#.00")
 
 /**
  * Coder ssh network metrics. All properties are optional
@@ -32,10 +35,15 @@ data class NetworkMetrics(
     val usingCoderConnect: Boolean?
 ) {
     fun toPretty(): String {
+        if (usingCoderConnect == true) {
+            return "You're connected using Coder Connect"
+        }
         return if (p2p == true) {
-            "Direct (${latency}ms) \u00B7 Download \u2193 $downloadBytesSec b/s \u00B7 Upload \u2191 $uploadBytesSec b/s"
+            "Direct (${formatter.format(latency)}ms). You're connected peer-to-peer"
         } else {
-            "$preferredDerp (${latency}ms) \u00B7 Download \u2193 $downloadBytesSec b/s \u00B7 Upload \u2191 $uploadBytesSec b/s"
+            val derpLatency = derpLatency!![preferredDerp]
+            val workspaceLatency = latency!!.minus(derpLatency!!)
+            "You ↔ $preferredDerp (${formatter.format(derpLatency)}ms) ↔ Workspace (${formatter.format(workspaceLatency)}ms). You are connected through a relay"
         }
     }
 }

src/main/resources/localization/defaultMessages.po

@@ -133,5 +133,5 @@ msgstr ""
 msgid "SSH network metrics directory"
 msgstr ""
 
-msgid "Network Metrics"
+msgid "Network Status"
 msgstr ""

src/test/kotlin/com/coder/toolbox/sdk/v2/models/NetworkMetricsTest.kt

@@ -0,0 +1,107 @@
+package com.coder.toolbox.sdk.v2.models
+
+import kotlin.test.Test
+import kotlin.test.assertEquals
+
+class NetworkMetricsTest {
+
+    @Test
+    fun `toPretty should return message for Coder Connect`() {
+        val metrics = NetworkMetrics(
+            p2p = null,
+            latency = null,
+            preferredDerp = null,
+            derpLatency = null,
+            uploadBytesSec = null,
+            downloadBytesSec = null,
+            usingCoderConnect = true
+        )
+
+        val expected = "You're connected using Coder Connect"
+        assertEquals(expected, metrics.toPretty())
+    }
+
+    @Test
+    fun `toPretty should return message for P2P connection`() {
+        val metrics = NetworkMetrics(
+            p2p = true,
+            latency = 35.526,
+            preferredDerp = null,
+            derpLatency = null,
+            uploadBytesSec = null,
+            downloadBytesSec = null,
+            usingCoderConnect = false
+        )
+
+        val expected = "Direct (35.53ms). You're connected peer-to-peer"
+        assertEquals(expected, metrics.toPretty())
+    }
+
+    @Test
+    fun `toPretty should round latency with more than two decimals correctly for P2P`() {
+        val metrics = NetworkMetrics(
+            p2p = true,
+            latency = 42.6789,
+            preferredDerp = null,
+            derpLatency = null,
+            uploadBytesSec = null,
+            downloadBytesSec = null,
+            usingCoderConnect = false
+        )
+
+        val expected = "Direct (42.68ms). You're connected peer-to-peer"
+        assertEquals(expected, metrics.toPretty())
+    }
+
+    @Test
+    fun `toPretty should pad latency with one decimal correctly for P2P`() {
+        val metrics = NetworkMetrics(
+            p2p = true,
+            latency = 12.5,
+            preferredDerp = null,
+            derpLatency = null,
+            uploadBytesSec = null,
+            downloadBytesSec = null,
+            usingCoderConnect = false
+        )
+
+        val expected = "Direct (12.50ms). You're connected peer-to-peer"
+        assertEquals(expected, metrics.toPretty())
+    }
+
+    @Test
+    fun `toPretty should return message for DERP relay connection`() {
+        val metrics = NetworkMetrics(
+            p2p = false,
+            latency = 80.0,
+            preferredDerp = "derp1",
+            derpLatency = mapOf("derp1" to 30.0),
+            uploadBytesSec = null,
+            downloadBytesSec = null,
+            usingCoderConnect = false
+        )
+
+        val expected = "You ↔ derp1 (30.00ms) ↔ Workspace (50.00ms). You are connected through a relay"
+        assertEquals(expected, metrics.toPretty())
+    }
+
+    @Test
+    fun `toPretty should round and pad latencies correctly for DERP`() {
+        val metrics = NetworkMetrics(
+            p2p = false,
+            latency = 78.1267,
+            preferredDerp = "derp2",
+            derpLatency = mapOf("derp2" to 23.5),
+            uploadBytesSec = null,
+            downloadBytesSec = null,
+            usingCoderConnect = false
+        )
+
+        // Total latency: 78.1267
+        // DERP latency: 23.5 → formatted as 23.50
+        // Workspace latency: 78.1267 - 23.5 = 54.6267 → formatted as 54.63
+
+        val expected = "You ↔ derp2 (23.50ms) ↔ Workspace (54.63ms). You are connected through a relay"
+        assertEquals(expected, metrics.toPretty())
+    }
+}