fix: ssh connection when wildcard config is enabled on Coder < 2.19.x

- Coder versions like 2.18.x and before that don't support the wildcard config.
  In this case, enabling this setting is ignored when generating the ssh config.
- however the hostname passed to the Toolbox ssh connection was not taking into
  account that some versions don't support wildcard config.
- this corner case is now covered by encapsulating the hostname resolving logic
  and taking into account the cli version.

Author: fioan89

src/main/kotlin/com/coder/toolbox/CoderRemoteEnvironment.kt

@@ -1,6 +1,7 @@
 package com.coder.toolbox
 
 import com.coder.toolbox.browser.BrowserUtil
+import com.coder.toolbox.cli.CoderCLIManager
 import com.coder.toolbox.models.WorkspaceAndAgentStatus
 import com.coder.toolbox.sdk.CoderRestClient
 import com.coder.toolbox.sdk.ex.APIResponseException
@@ -35,6 +36,7 @@ import kotlin.time.Duration.Companion.seconds
 class CoderRemoteEnvironment(
     private val context: CoderToolboxContext,
     private val client: CoderRestClient,
+    private val cli: CoderCLIManager,
     private var workspace: Workspace,
     private var agent: WorkspaceAgent,
 ) : RemoteProviderEnvironment("${workspace.name}.${agent.name}"), BeforeConnectionHook, AfterDisconnectHook {
@@ -155,6 +157,7 @@ class CoderRemoteEnvironment(
     fun getContentsView(): EnvironmentContentsView = EnvironmentView(
         context.settingsStore.readOnly(),
         client.url,
+        cli,
         workspace,
         agent
     )

src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt

@@ -91,7 +91,7 @@ class CoderRemoteProvider(
                             it.name
                         }?.map { agent ->
                             // If we have an environment already, update that.
-                            val env = CoderRemoteEnvironment(context, client, ws, agent)
+                            val env = CoderRemoteEnvironment(context, client, cli, ws, agent)
                             lastEnvironments.firstOrNull { it == env }?.let {
                                 it.update(ws, agent)
                                 it

src/main/kotlin/com/coder/toolbox/cli/CoderCLIManager.kt

@@ -511,25 +511,27 @@ class CoderCLIManager(
             }
         }
 
+    fun getHostname(url: URL, ws: Workspace, agent: WorkspaceAgent): String {
+        return if (settings.isSshWildcardConfigEnabled && features.wildcardSsh) {
+            "${getHostnamePrefix(url)}--${ws.ownerName}--${ws.name}.${agent.name}"
+        } else {
+            "coder-jetbrains-toolbox--${ws.ownerName}--${ws.name}.${agent.name}--${url.safeHost()}"
+        }
+    }
+
+    fun getBackgroundHostname(url: URL, ws: Workspace, agent: WorkspaceAgent): String {
+        return "${getHostname(url, ws, agent)}--bg"
+    }
+
     companion object {
         private val tokenRegex = "--token [^ ]+".toRegex()
 
         private fun getHostnamePrefix(url: URL): String = "coder-jetbrains-toolbox-${url.safeHost()}"
 
         private fun getBackgroundHostnamePrefix(url: URL): String = "coder-jetbrains-toolbox-${url.safeHost()}-bg"
 
-        fun getWildcardHostname(url: URL, ws: Workspace, agent: WorkspaceAgent): String =
-            "${getHostnamePrefix(url)}--${ws.ownerName}--${ws.name}.${agent.name}"
-
-        fun getHostname(url: URL, ws: Workspace, agent: WorkspaceAgent): String {
-            return "coder-jetbrains-toolbox--${ws.ownerName}--${ws.name}.${agent.name}--${url.safeHost()}"
-        }
-
-        fun getBackgroundHostname(url: URL, ws: Workspace, agent: WorkspaceAgent): String {
-            return "${getHostname(url, ws, agent)}--bg"
-        }
-
-        private fun getWsByOwner(ws: Workspace, agent: WorkspaceAgent): String = "${ws.ownerName}/${ws.name}.${agent.name}"
+        private fun getWsByOwner(ws: Workspace, agent: WorkspaceAgent): String =
+            "${ws.ownerName}/${ws.name}.${agent.name}"
 
         private fun Pair<Workspace, WorkspaceAgent>.workspace() = this.first
 

src/main/kotlin/com/coder/toolbox/views/EnvironmentView.kt

@@ -19,14 +19,15 @@ import java.net.URL
 class EnvironmentView(
     private val settings: ReadOnlyCoderSettings,
     private val url: URL,
+    private val cli: CoderCLIManager,
     private val workspace: Workspace,
     private val agent: WorkspaceAgent,
 ) : SshEnvironmentContentsView {
     override suspend fun getConnectionInfo(): SshConnectionInfo = object : SshConnectionInfo {
         /**
          * The host name generated by the cli manager for this workspace.
          */
-        override val host: String = resolveHost()
+        override val host: String = cli.getHostname(url, workspace, agent)
 
         /**
          * The port is ignored by the Coder proxy command.
@@ -37,11 +38,5 @@ class EnvironmentView(
          * The username is ignored by the Coder proxy command.
          */
         override val userName: String? = null
-
     }
-
-    private fun resolveHost(): String =
-        if (settings.isSshWildcardConfigEnabled)
-            CoderCLIManager.getWildcardHostname(url, workspace, agent)
-        else CoderCLIManager.getHostname(url, workspace, agent)
-}
+}