fix: exception collector was never reset

- forcing the main screen to always show the same exception
- this patch refactors the code to accumulate the errors in a buffer and show them when auth screen is visible
- in addition, the error reporting uses the Snackbar api which provides greater control, and the possibility
  to stack errors one on top of each other. This approach simplifies the code on our side even more because
  the ui page no longer needs to accumulate the errors in a buffer and process them when a notifier is
  injected by toolbox.

Author: fioan89

src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt

@@ -61,7 +61,7 @@ class CoderRemoteProvider(
     // If we have an error in the polling we store it here before going back to
     // sign-in page, so we can display it there.  This is mainly because there
     // does not seem to be a mechanism to show errors on the environment list.
-    private var pollError: Exception? = null
+    private var errorBuffer = mutableListOf<Throwable>()
 
     // On the first load, automatically log in if we can.
     private var firstRun = true
@@ -142,19 +142,19 @@ class CoderRemoteProvider(
                     client.setupSession()
                 } else {
                     context.logger.error(ex, "workspace polling error encountered")
-                    pollError = ex
+                    errorBuffer.add(ex)
                     logout()
                     break
                 }
             } catch (ex: APIResponseException) {
                 context.logger.error(ex, "error in contacting ${client.url} while polling the available workspaces")
-                pollError = ex
+                errorBuffer.add(ex)
                 logout()
                 goToEnvironmentsPage()
                 break
             } catch (ex: Exception) {
                 context.logger.error(ex, "workspace polling error encountered")
-                pollError = ex
+                errorBuffer.add(ex)
                 logout()
                 goToEnvironmentsPage()
                 break
@@ -308,15 +308,14 @@ class CoderRemoteProvider(
         if (client == null) {
             // When coming back to the application, authenticate immediately.
             val autologin = shouldDoAutoLogin()
-            var autologinEx: Exception? = null
             context.secrets.lastToken.let { lastToken ->
                 context.secrets.lastDeploymentURL.let { lastDeploymentURL ->
                     if (autologin && lastDeploymentURL.isNotBlank() && (lastToken.isNotBlank() || !settings.requireTokenAuth)) {
                         try {
                             AuthWizardState.goToStep(WizardStep.LOGIN)
                             return AuthWizardPage(context, true, ::onConnect)
                         } catch (ex: Exception) {
-                            autologinEx = ex
+                            errorBuffer.add(ex)
                         }
                     }
                 }
@@ -325,11 +324,12 @@ class CoderRemoteProvider(
 
             // Login flow.
             val authWizard = AuthWizardPage(context, false, ::onConnect)
-            // We might have tried and failed to automatically log in.
-            autologinEx?.let { authWizard.notify("Error logging in", it) }
             // We might have navigated here due to a polling error.
-            pollError?.let { authWizard.notify("Error fetching workspaces", it) }
-
+            errorBuffer.forEach {
+                authWizard.notify("Error encountered", it)
+            }
+            // and now reset the errors, otherwise we show it every time on the screen
+            errorBuffer.clear()
             return authWizard
         }
         return null
@@ -344,7 +344,7 @@ class CoderRemoteProvider(
         // Currently we always remember, but this could be made an option.
         context.secrets.rememberMe = true
         this.client = client
-        pollError = null
+        errorBuffer.clear()
         pollJob?.cancel()
         pollJob = poll(client, cli)
         goToEnvironmentsPage()

src/main/kotlin/com/coder/toolbox/views/CoderPage.kt

@@ -6,6 +6,8 @@ import com.jetbrains.toolbox.api.core.ui.icons.SvgIcon.IconType
 import com.jetbrains.toolbox.api.localization.LocalizableString
 import com.jetbrains.toolbox.api.ui.actions.RunnableActionDescription
 import com.jetbrains.toolbox.api.ui.components.UiPage
+import kotlinx.coroutines.launch
+import java.util.UUID
 
 /**
  * Base page that handles the icon, displaying error notifications, and
@@ -23,12 +25,6 @@ abstract class CoderPage(
     showIcon: Boolean = true,
 ) : UiPage(title) {
 
-    /** Toolbox uses this to show notifications on the page. */
-    private var notifier: ((Throwable) -> Unit)? = null
-
-    /** Stores errors until the notifier is attached. */
-    private var errorBuffer: MutableList<Throwable> = mutableListOf()
-
     /**
      * Return the icon, if showing one.
      *
@@ -48,20 +44,13 @@ abstract class CoderPage(
      */
     fun notify(logPrefix: String, ex: Throwable) {
         context.logger.error(ex, logPrefix)
-        // It is possible the error listener is not attached yet.
-        notifier?.let { it(ex) } ?: errorBuffer.add(ex)
-    }
-
-    /**
-     * Immediately notify any pending errors and store for later errors.
-     */
-    override fun setActionErrorNotifier(notifier: ((Throwable) -> Unit)?) {
-        this.notifier = notifier
-        notifier?.let {
-            errorBuffer.forEach {
-                notifier(it)
-            }
-            errorBuffer.clear()
+        context.cs.launch {
+            context.ui.showSnackbar(
+                UUID.randomUUID().toString(),
+                context.i18n.pnotr(logPrefix),
+                context.i18n.pnotr(ex.message ?: ""),
+                context.i18n.ptrl("Dismiss")
+            )
         }
     }
 }