review fixes

Author: kirillk

src/main/kotlin/com/coder/gateway/CoderRemoteConnectionHandle.kt

@@ -413,10 +413,9 @@ class CoderRemoteConnectionHandle {
     ) {
         if (setupCommand.isNotBlank()) {
             indicator.text = "Running setup command..."
-            processSetupCommand(
-                { exec(workspace, setupCommand) },
-                ignoreSetupFailure
-            )
+            processSetupCommand(ignoreSetupFailure) {
+                exec(workspace, setupCommand)
+            }
         } else {
             logger.info("No setup command to run on ${workspace.hostname}")
         }
@@ -523,11 +522,11 @@ class CoderRemoteConnectionHandle {
     companion object {
         val logger = Logger.getInstance(CoderRemoteConnectionHandle::class.java.simpleName)
         fun processSetupCommand(
-            output: () -> String,
-            ignoreSetupFailure: Boolean
+            ignoreSetupFailure: Boolean,
+            execCommand: () -> String
         ) {
             try {
-                val errorText = output
+                val errorText = execCommand
                     .invoke()
                     .lines()
                     .firstOrNull { it.contains(GATEWAY_SETUP_COMMAND_ERROR) }

src/test/kotlin/com/coder/gateway/util/SetupCommandTest.kt

@@ -12,36 +12,36 @@ internal class SetupCommandTest {
         assertEquals(
             "Execution error",
             assertThrows<Exception> {
-                processSetupCommand({ throw Exception("Execution error") }, false)
+                processSetupCommand(false) { throw Exception("Execution error") }
             }.message
         )
-        processSetupCommand({ throw Exception("Execution error") }, true)
+        processSetupCommand(true) { throw Exception("Execution error") }
     }
 
     @Test
     fun setupScriptError() {
         assertEquals(
             "Your IDE is expired, please update",
             assertThrows<Exception> {
-                processSetupCommand({
-                """
+                processSetupCommand(false) {
+                    """
                 execution line 1    
                 execution line 2
                 CODER_SETUP_ERRORYour IDE is expired, please update
                 execution line 3    
                 """
-                }, false)
+                }
             }.message
         )
 
-        processSetupCommand({
+        processSetupCommand(true) {
             """
                 execution line 1    
                 execution line 2
                 CODER_SETUP_ERRORYour IDE is expired, please update
                 execution line 3    
                 """
-        }, true)
+        }
 
     }
 }