Don't panic on nil values

ammario · ammario · commit cd356cb7843a · 2023-05-09T00:51:53.000-05:00
diff --git a/internal/entryhuman/entry.go b/internal/entryhuman/entry.go
@@ -57,6 +57,9 @@ func reset(w io.Writer, termW io.Writer) {
 }
 
 func formatValue(v interface{}) string {
+	if v == nil {
+		return "<nil>"
+	}
 	typ := reflect.TypeOf(v)
 	switch typ.Kind() {
 	case reflect.Struct, reflect.Map:
diff --git a/internal/entryhuman/entry_test.go b/internal/entryhuman/entry_test.go
@@ -86,6 +86,15 @@ func TestEntry(t *testing.T) {
 				),
 			},
 		},
+		{
+			"nil",
+			slog.SinkEntry{
+				Level: slog.LevelWarn,
+				Fields: slog.M(
+					slog.F("nan", nil),
+				),
+			},
+		},
 		{
 			"bytes",
 			slog.SinkEntry{
diff --git a/internal/entryhuman/testdata/nil.golden b/internal/entryhuman/testdata/nil.golden
@@ -0,0 +1 @@
+0001-01-01 00:00:00.000 [warn]    nan=<nil>

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,9 @@ func reset(w io.Writer, termW io.Writer) {`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`func formatValue(v interface{}) string {`
	`60`	`+ if v == nil {`
	`61`	`+ return "<nil>"`
	`62`	`+ }`
`60`	`63`	`typ := reflect.TypeOf(v)`
`61`	`64`	`switch typ.Kind() {`
`62`	`65`	`case reflect.Struct, reflect.Map:`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+0001-01-01 00:00:00.000 [warn] nan=<nil>`