Review comments

Author: EhabY

src/extension.ts

@@ -278,76 +278,50 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
 			"coder.login",
 			commands.login.bind(commands),
 		),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand(
 			"coder.logout",
 			commands.logout.bind(commands),
 		),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand("coder.open", commands.open.bind(commands)),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand(
 			"coder.openDevContainer",
 			commands.openDevContainer.bind(commands),
 		),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand(
 			"coder.openFromSidebar",
 			commands.openFromSidebar.bind(commands),
 		),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand(
 			"coder.openAppStatus",
 			commands.openAppStatus.bind(commands),
 		),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand(
 			"coder.workspace.update",
 			commands.updateWorkspace.bind(commands),
 		),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand(
 			"coder.createWorkspace",
 			commands.createWorkspace.bind(commands),
 		),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand(
 			"coder.navigateToWorkspace",
 			commands.navigateToWorkspace.bind(commands),
 		),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand(
 			"coder.navigateToWorkspaceSettings",
 			commands.navigateToWorkspaceSettings.bind(commands),
 		),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand("coder.refreshWorkspaces", () => {
 			myWorkspacesProvider.fetchAndRefresh();
 			allWorkspacesProvider.fetchAndRefresh();
 		}),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand(
 			"coder.viewLogs",
 			commands.viewLogs.bind(commands),
 		),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand("coder.searchMyWorkspaces", async () =>
 			showTreeViewSearch(MY_WORKSPACES_TREE_ID),
 		),
-	);
-	ctx.subscriptions.push(
 		vscode.commands.registerCommand("coder.searchAllWorkspaces", async () =>
 			showTreeViewSearch(ALL_WORKSPACES_TREE_ID),
 		),

src/remote/remote.ts

@@ -400,7 +400,9 @@ export class Remote {
 				workspace.owner_name,
 				workspace.name,
 			);
-			disposables.push(labelFormatterDisposable);
+			disposables.push({
+				dispose: () => labelFormatterDisposable.dispose(),
+			});
 
 			// If the workspace is not in a running state, try to get it running.
 			if (workspace.latest_build.status !== "running") {
@@ -637,11 +639,7 @@ export class Remote {
 						workspace.name,
 						agent.name,
 					);
-					disposables.push(labelFormatterDisposable);
 				}),
-			);
-
-			disposables.push(
 				...this.createAgentMetadataStatusBar(agent, workspaceClient),
 			);
 		} catch (ex) {