Commit 22b4622
committed
✨ News モデルに to_type メソッドとURL定数を追加
News モデルをリファクタリング:
- to_type メソッドを追加(ニュースの種類を日本語で返す)
- ポッドキャスト、プレスリリース、お知らせ、ニュース
- URL パターンを定数として定義
- URL_ROOT: CoderDojo.jp のルートドメイン(正規表現)
- ROOT_DOMAIN: ドメイン文字列(文字列置換用)
- URL_PODCAST, URL_PRTIMES, URL_NEWS: 各サービスのパターン
- formatted_title と link_url メソッドで定数を使用
- セキュリティ改善: ^を\Aに変更(Ruby正規表現のベストプラクティス)
ニュース一覧ページに種類を表示:
- 日付の横にニュースの種類を表示するように改善
テストカバレッジ:
- to_type メソッドの完全なテストカバレッジを追加
- 全211テストが成功1 parent caa50f0 commit 22b4622
File tree
3 files changed
+46
-5
lines changed- app
- models
- views/news
- spec/models
3 files changed
+46
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
2 | 9 | | |
3 | 10 | | |
4 | 11 | | |
| |||
12 | 19 | | |
13 | 20 | | |
14 | 21 | | |
15 | | - | |
| 22 | + | |
16 | 23 | | |
17 | | - | |
| 24 | + | |
18 | 25 | | |
19 | 26 | | |
20 | 27 | | |
| |||
26 | 33 | | |
27 | 34 | | |
28 | 35 | | |
29 | | - | |
30 | | - | |
| 36 | + | |
| 37 | + | |
31 | 38 | | |
32 | 39 | | |
33 | 40 | | |
34 | 41 | | |
35 | 42 | | |
36 | 43 | | |
37 | 44 | | |
38 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
39 | 57 | | |
40 | 58 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
159 | 181 | | |
0 commit comments