Add Firefox and Safari to Selenium test suite

Author: codingjoe

.github/workflows/ci.yml

@@ -57,13 +57,18 @@ jobs:
   selenium:
     needs:
       - pytest
-    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v6
       - name: Install Selenium
         run: |
-          wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
+          curl -LsSfO https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
           sudo dpkg -i google-chrome-stable_current_amd64.deb || sudo apt-get -f install -y
+        if: matrix.os == 'ubuntu-latest'
       - uses: astral-sh/setup-uv@v7
       - run: uv run pytest -m selenium
       - uses: codecov/codecov-action@v5

tests/conftest.py

@@ -14,12 +14,12 @@ def pytest_configure(config):
     config.addinivalue_line("markers", "selenium: skip if selenium is not installed")
 
 
-@pytest.fixture(scope="session")
-def driver():
-    chrome_options = webdriver.ChromeOptions()
-    chrome_options.add_argument("--headless=new")
+@pytest.fixture(scope="session", params=["Chrome", "Safari", "Firefox"])
+def driver(request):
+    options = getattr(webdriver, f"{request.param}Options")()
+    options.add_argument("--headless")
     try:
-        b = webdriver.Chrome(options=chrome_options)
+        b = getattr(webdriver, request.param)(options=options)
     except WebDriverException as e:
         pytest.skip(force_str(e))
     else:

tests/test_forms.py

@@ -210,12 +210,12 @@ def test_file_insert(
     def test_file_update(
         self, request, driver, live_server, upload_file, freeze_upload_folder
     ):
-        FileModel.objects.create(
+        obj = FileModel.objects.create(
             file=SimpleUploadedFile(
                 f"{request.node.name}.txt", request.node.name.encode()
             )
         )
-        driver.get(live_server + reverse_lazy("example-update", kwargs={"pk": 1}))
+        driver.get(live_server + reverse_lazy("example-update", kwargs={"pk": obj.pk}))
         file_input = driver.find_element(By.XPATH, "//input[@name='file']")
         file_input.send_keys(upload_file)
         assert file_input.get_attribute("name") == "file"
@@ -288,7 +288,7 @@ def test_multi_file(
         driver.get(live_server + reverse_lazy("upload-multi"))
         file_input = driver.find_element(By.XPATH, "//input[@name='file']")
         file_input.send_keys(
-            " \n ".join([
+            "\n".join([
                 str(freeze_upload_folder / upload_file),
                 str(freeze_upload_folder / another_upload_file),
             ])

tests/testapp/views.py

@@ -30,6 +30,7 @@ def form_valid(self, form):
             },
             status=201,
             encoder=FileEncoder,
+            content_type="text/plain",
         )
 
 
@@ -49,6 +50,7 @@ def form_valid(self, form):
             },
             status=201,
             encoder=FileEncoder,
+            content_type="text/plain",
         )
 
 
@@ -67,4 +69,5 @@ def form_valid(self, form):
             },
             status=201,
             encoder=FileEncoder,
+            content_type="text/plain",
         )