This repository was archived by the owner on Feb 19, 2024. It is now read-only.
This repository was archived by the owner on Feb 19, 2024. It is now read-only.
json_pure is trowing warnings in ruby 2.7 #29
Description
One of the transient dependencies from packagecloud-ruby gem is json_pure, and it is locked to a very old version: 1.8.1. Running pacakge_cloud in ruby 2.7 is throwing warnings due to the kwargs deprecations for future 3.0 compatibility:
./builds/gitlab-org/build/omnibus-gitlab-mirror/gems/ruby/2.7.0/gems/json_pure-1.8.1/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
I remember from a discussion in the past that package_cloud gem was still support ruby 1.8 (which I think is why you are locked to this version). Is this still the case? Do you have any intention or are open to a MR that updates some dependencies for newer ruby's compatibility?
GitLab issue: https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/5807