Skip to content

Commit 432a69e

Browse files
authored
Enhance onboarding (#426)
* Update requirements and refactor User class * Bump version to 2.1.9.dev1 * Update version to 2.1.9
1 parent 21690e1 commit 432a69e

File tree

8 files changed

+96
-148
lines changed

8 files changed

+96
-148
lines changed

cuenca/resources/users.py

Lines changed: 6 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,14 @@
99
PhoneNumber,
1010
SATRegimeCode,
1111
TOSAgreement,
12-
TOSRequest,
1312
UserQuery,
1413
UserRequest,
1514
UserStatus,
1615
UserUpdateRequest,
1716
)
1817
from cuenca_validations.types.enums import Country, Gender, State
1918
from cuenca_validations.types.general import SerializableHttpUrl
20-
from cuenca_validations.types.identities import Curp
19+
from cuenca_validations.types.identities import AddressRequest, Curp
2120
from pydantic import ConfigDict, EmailStr, Field
2221

2322
from ..http import Session, session as global_session
@@ -107,70 +106,54 @@ def balance(self) -> int:
107106
def create(
108107
cls,
109108
curp: Curp,
110-
phone_number: Optional[PhoneNumber] = None,
111-
email_address: Optional[EmailStr] = None,
112109
profession: Optional[str] = None,
113-
address: Optional[Address] = None,
110+
address: Optional[AddressRequest] = None,
114111
email_verification_id: Optional[str] = None,
115112
phone_verification_id: Optional[str] = None,
116-
status: Optional[UserStatus] = None,
117-
required_level: Optional[int] = None,
118-
terms_of_service: Optional[TOSRequest] = None,
119113
*,
120114
session: Session = global_session,
121115
) -> 'User':
122116
req = UserRequest(
123117
curp=curp,
124-
phone_number=phone_number,
125-
email_address=email_address,
126118
profession=profession,
127119
address=address,
128120
email_verification_id=email_verification_id,
129121
phone_verification_id=phone_verification_id,
130-
required_level=required_level,
131-
status=status,
132-
terms_of_service=terms_of_service,
133122
)
134123
return cls._create(session=session, **req.model_dump())
135124

136125
@classmethod
137126
def update(
138127
cls,
139128
user_id: str,
140-
phone_number: Optional[PhoneNumber] = None,
141-
email_address: Optional[str] = None,
142129
profession: Optional[str] = None,
143-
address: Optional[Address] = None,
130+
address: Optional[AddressRequest] = None,
144131
beneficiaries: Optional[list[Beneficiary]] = None,
145132
govt_id: Optional[KYCFile] = None,
146133
proof_of_address: Optional[KYCFile] = None,
147134
proof_of_life: Optional[KYCFile] = None,
148-
terms_of_service: Optional[TOSRequest] = None,
149-
verification_id: Optional[str] = None,
150135
status: Optional[UserStatus] = None,
151136
email_verification_id: Optional[str] = None,
152137
phone_verification_id: Optional[str] = None,
153138
curp_document: Optional[SerializableHttpUrl] = None,
154139
fiscal_regime_code: Optional[SATRegimeCode] = None,
140+
pronouns: Optional[str] = None,
155141
*,
156142
session: Session = global_session,
157143
) -> 'User':
158144
request = UserUpdateRequest(
159-
phone_number=phone_number,
160-
email_address=email_address,
161145
profession=profession,
162146
address=address,
163147
beneficiaries=beneficiaries,
164148
govt_id=govt_id,
165149
proof_of_address=proof_of_address,
166150
proof_of_life=proof_of_life,
167-
terms_of_service=terms_of_service,
168-
verification_id=verification_id,
151+
status=status,
169152
email_verification_id=email_verification_id,
170153
phone_verification_id=phone_verification_id,
171154
curp_document=curp_document,
172155
fiscal_regime_code=fiscal_regime_code,
173-
status=status,
156+
pronouns=pronouns,
174157
)
175158
return cls._update(id=user_id, **request.model_dump(), session=session)
176159

cuenca/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
__version__ = '2.1.8'
1+
__version__ = '2.1.9'
22
CLIENT_VERSION = __version__
33
API_VERSION = '2020-03-19'

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
requests==2.32.3
2-
cuenca-validations==2.1.13
2+
cuenca-validations==2.1.14
33
pydantic-extra-types==2.10.2

tests/conftest.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ def curp_validation_request() -> dict:
3636
names='José',
3737
first_surname='López',
3838
second_surname='Hernández',
39-
date_of_birth=dt.date(1966, 6, 6),
40-
state_of_birth=State.DF,
39+
date_of_birth=dt.date(1996, 6, 21),
40+
state_of_birth=State.GR,
4141
country_of_birth=Country.MX,
4242
gender=Gender.male,
4343
)
@@ -48,17 +48,15 @@ def curp_validation_request() -> dict:
4848
def user_request() -> dict:
4949
user_dict = dict(
5050
curp='LOHJ660606HDFPRS02',
51-
phone_number='+525511223344',
52-
email_address='jose@test.com',
5351
profession=Profession.empleado,
5452
address=dict(
5553
street='calle 1',
5654
ext_number='2',
5755
int_number='3',
58-
postal_code_id='PC2ygq9j2bS9-9tsuVawzErA',
56+
postal_code_id='PCLo4hi65YTKaAnph27E_2SQ',
5957
),
60-
phone_verification_id='VERdkuqOCjSA2PSS-VCj7HhQ',
61-
email_verification_id='VERppwdqsQSAQFFF-CDsWD8s',
58+
phone_verification_id='VEJlFhtVOgQMG5EpkThHL5Tg',
59+
email_verification_id='VE_r7hBIlaSfe2pEOvMtBEog',
6260
)
6361
return user_dict
6462

0 commit comments

Comments
 (0)