Can only specify a visaulization once

[samwalkow]

Description

Once you pick a visualization, that option disappears. What if you want to create a list of two projection plots? That's not possible right now.

What I Did

In the schema_model.py file, this is how the Plot attribute is set up. How can we reuse specifications?

 Plot: Optional[List[Visualizations]]

I think we'll have to change the Visaulizations dataclass. Maybe we make more lists?

Right now we have:

class Visualizations(ytBaseModel):
    """
    This class organizes the attributes below so users
    can select the plot by name,
    and see the correct arguments as suggestions
    """

    SlicePlot: Optional[SlicePlot]
    ProjectionPlot: Optional[ProjectionPlot]
    PhasePlot: Optional[PhasePlot]

Should it be:

    SlicePlot: Optional[List[SlicePlot]]
    ProjectionPlot: Optional[List[ProjectionPlot]]
    PhasePlot: Optional[List[PhasePlot]]

[chrishavlin]

I think your suggestion of putting the *Plots into lists would work. If we do that, how do you feel about renaming the Visualizations attributes to be plural? i.e.,:

class Visualizations(ytBaseModel):
    """
    This class organizes the attributes below so users
    can select the plot by name,
    and see the correct arguments as suggestions
    """

    SlicePlots: Optional[List[SlicePlot]]
    ProjectionPlots: Optional[List[ProjectionPlot]]
    PhasePlots: Optional[List[PhasePlot]]

IMO it's a nice way to grammatically signal that you can put multiples of any of them.

The new Visualizations runner in _model_instantiation would need some minor tweaking to account for the lists. See here:

analysis_schema/analysis_schema/_model_instantiation.py

Lines 155 to 164 in f264deb

	def process_pydantic(self, pydantic_instance: data_classes.Visualizations, ds=None):
	generic_runner = YTGeneric()
	viz_results = {}
	for attr in pydantic_instance.__fields__.keys():
	viz_model = getattr(pydantic_instance, attr) # SlicePlot, etc.
	if viz_model is not None:
	result = generic_runner.run(viz_model, ds=ds)
	nme = f"{ds.basename}_{attr}"
	viz_results[nme] = self._sanitize_viz(viz_model, result)
	return viz_results