-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
Currently, DockerClient can't be used without ssh2 (a very large dependency) being in the dependency tree, despite it only being used in one branch of DockerClient.fromDockerHost. If consumers don't connect over ssh, they shouldn't need that dependency.
I'd recommend:
- Moving the static members out of
DockerClientand into their own modules. That should solve the dependency tree problem (via tree-shaking) for anybody bundling their app - For everyone else (and just to minimise
node_modulesimpact), it'd be good to also makessh2an optional peer dependency and make thessh://-specific code paths fail if it's not present
Metadata
Metadata
Assignees
Labels
No labels