objdiff-wasm: Fix symbol filtering

regex crate needed the `unicode-case` feature

Author: encounter

Cargo.lock

@@ -14,7 +14,7 @@ strip = "debuginfo"
 codegen-units = 1
 
 [workspace.package]
-version = "3.0.0-beta.2"
+version = "3.0.0-beta.3"
 authors = ["Luke Street <luke@street.dev>"]
 edition = "2024"
 license = "MIT OR Apache-2.0"

Cargo.toml

@@ -563,7 +563,7 @@ pub fn instruction_hover(
     out
 }
 
-#[derive(Copy, Clone)]
+#[derive(Debug, Copy, Clone)]
 pub enum SymbolFilter<'a> {
     None,
     Search(&'a Regex),

objdiff-core/src/diff/display.rs

@@ -24,7 +24,7 @@ std = ["objdiff-core/std"]
 
 [dependencies]
 log = { version = "0.4", default-features = false }
-regex = { version = "1.11", default-features = false }
+regex = { version = "1.11", default-features = false, features = ["unicode-case"] }
 
 [dependencies.objdiff-core]
 path = "../objdiff-core"
@@ -35,7 +35,7 @@ features = ["arm", "arm64", "mips", "ppc", "x86", "dwarf"]
 talc = { version = "4.4", default-features = false, features = ["lock_api"] }
 
 [target.'cfg(target_os = "wasi")'.dependencies]
-wit-bindgen = { version = "0.39", default-features = false, features = ["macros"] }
+wit-bindgen = { version = "0.40", default-features = false, features = ["macros"] }
 
 [build-dependencies]
 wit-deps = "0.5"

objdiff-wasm/Cargo.toml

@@ -1,6 +1,6 @@
 {
   "name": "objdiff-wasm",
-  "version": "3.0.0-beta.2",
+  "version": "3.0.0-beta.3",
   "description": "A local diffing tool for decompilation projects.",
   "author": {
     "name": "Luke Street",

objdiff-wasm/package-lock.json

@@ -8,7 +8,7 @@ use alloc::{
 use core::cell::RefCell;
 
 use objdiff_core::{diff, obj};
-use regex::RegexBuilder;
+use regex::{Regex, RegexBuilder};
 
 use super::logging;
 
@@ -86,19 +86,31 @@ impl GuestDiff for Component {
     }
 }
 
+fn build_regex(s: &str) -> Option<Regex> {
+    if s.is_empty() {
+        return None;
+    }
+    let e = match RegexBuilder::new(s).case_insensitive(true).build() {
+        Ok(regex) => return Some(regex),
+        Err(e) => e,
+    };
+    // Use the string as a literal if the regex fails to compile
+    let escaped = regex::escape(s);
+    if let Ok(regex) = RegexBuilder::new(&escaped).case_insensitive(true).build() {
+        return Some(regex);
+    }
+    // Use the original error if the escaped string also fails
+    log::warn!("Failed to compile regex: {}", e);
+    None
+}
+
 impl GuestDisplay for Component {
     fn display_sections(
         diff: ObjectDiffBorrow,
         filter: SymbolFilter,
         config: DisplayConfig,
     ) -> Vec<SectionDisplay> {
-        let regex = filter.regex.as_ref().and_then(|s| {
-            RegexBuilder::new(s).case_insensitive(true).build().ok().or_else(|| {
-                // Use the string as a literal if the regex fails to compile
-                let escaped = regex::escape(s);
-                RegexBuilder::new(&escaped).case_insensitive(true).build().ok()
-            })
-        });
+        let regex = filter.regex.as_deref().and_then(build_regex);
         let filter = if let Some(mapping) = filter.mapping {
             diff::display::SymbolFilter::Mapping(mapping as usize, regex.as_ref())
         } else if let Some(regex) = &regex {