-
Notifications
You must be signed in to change notification settings - Fork 631
feat(py): add mcp plugin and tests #4054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @MengqinShen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Model Context Protocol (MCP) into the Python Genkit SDK by adding a new plugin. This plugin allows Genkit applications to seamlessly connect to and utilize services from external MCP servers, as well as to expose their own defined tools, prompts, and resources as an MCP server. The changes also include improvements to Genkit's core resource definition mechanism for greater adaptability and are accompanied by comprehensive examples and tests to ensure robust functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new MCP (Model Context Protocol) plugin for Python, along with comprehensive examples and tests. The implementation is well-structured and largely mirrors the existing JavaScript SDK, which is great for consistency.
I've identified a few areas for improvement:
- A potential runtime error in
define_resourcedue to an optional function argument that is required by a downstream call. - A missing
input_schemawhen registering tools from an MCP client, which is important for Genkit's tool-use capabilities. - Some minor maintainability issues like local imports and brittle string-based lookups.
Overall, this is a great addition. Addressing these points will make the new plugin more robust and maintainable.
This big changes aims to add mcp plugin to mirror all the functionalities in js/plugins/mcp in JS SDK.
CHANGELOG: