fix tests and bundle with npm run all

Author: GrantBirki

__tests__/functions/valid-permissions.test.js

@@ -2,15 +2,21 @@ import * as core from '@actions/core'
 import {validPermissions} from '../../src/functions/valid-permissions'
 
 const setOutputMock = jest.spyOn(core, 'setOutput')
+const infoMock = jest.spyOn(core, 'info')
 
 var octokit
 var context
 beforeEach(() => {
   jest.clearAllMocks()
   jest.spyOn(core, 'setOutput').mockImplementation(() => {})
+  jest.spyOn(core, 'info').mockImplementation(() => {})
   process.env.INPUT_PERMISSIONS = 'write,admin'
 
   context = {
+    repo: {
+      owner: 'corp',
+      repo: 'test'
+    },
     actor: 'monalisa'
   }
 
@@ -42,6 +48,9 @@ beforeEach(() => {
 test('determines that a user has valid permissions to invoke the Action', async () => {
   expect(await validPermissions(octokit, context)).toEqual(true)
   expect(setOutputMock).toHaveBeenCalledWith('actor', 'monalisa')
+  expect(infoMock).toHaveBeenCalledWith(
+    `🔍 Detected actor type: User (${context.actor})`
+  )
 })
 
 test('determines that a user has does not valid permissions to invoke the Action', async () => {
@@ -60,6 +69,17 @@ test('determines that a user has does not valid permissions to invoke the Action
   expect(setOutputMock).toHaveBeenCalledWith('actor', 'monalisa')
 })
 
+test('fails to get actor information', async () => {
+  octokit.rest.users.getByUsername = jest.fn().mockReturnValue({
+    status: 500
+  })
+
+  expect(await validPermissions(octokit, context)).toEqual(
+    'Fetch user details returns non-200 status: 500'
+  )
+  expect(setOutputMock).toHaveBeenCalledWith('actor', 'monalisa')
+})
+
 test('fails to get actor permissions due to a bad status code', async () => {
   octokit.rest.repos.getCollaboratorPermissionLevel = jest
     .fn()
@@ -76,14 +96,14 @@ test('fails to get actor permissions due to a bad status code', async () => {
 test('determines that a GitHub App has valid permissions', async () => {
   context.actor = 'github-actions[bot]'
 
-  octokit.rest.users.getByUsername.mockReturnValueOnce({
+  octokit.rest.users.getByUsername = jest.fn().mockReturnValueOnce({
     status: 200,
     data: {
       type: 'Bot'
     }
   })
 
-  octokit.rest.apps.getRepoInstallation.mockReturnValueOnce({
+  octokit.rest.apps.getRepoInstallation = jest.fn().mockReturnValueOnce({
     status: 200,
     data: {
       permissions: {
@@ -94,19 +114,22 @@ test('determines that a GitHub App has valid permissions', async () => {
 
   expect(await validPermissions(octokit, context)).toEqual(true)
   expect(setOutputMock).toHaveBeenCalledWith('actor', 'github-actions[bot]')
+  expect(infoMock).toHaveBeenCalledWith(
+    `🔍 Detected actor type: Bot (${context.actor})`
+  )
 })
 
 test('determines that a GitHub App does not have valid permissions', async () => {
   context.actor = 'monalisa[bot]'
 
-  octokit.rest.users.getByUsername.mockReturnValueOnce({
+  octokit.rest.users.getByUsername = jest.fn().mockReturnValueOnce({
     status: 200,
     data: {
       type: 'Bot'
     }
   })
 
-  octokit.rest.apps.getRepoInstallation.mockReturnValueOnce({
+  octokit.rest.apps.getRepoInstallation = jest.fn().mockReturnValueOnce({
     status: 200,
     data: {
       permissions: {
@@ -124,14 +147,14 @@ test('determines that a GitHub App does not have valid permissions', async () =>
 test('fails to fetch installation details for GitHub App', async () => {
   context.actor = 'monalisa[bot]'
 
-  octokit.rest.users.getByUsername.mockReturnValueOnce({
+  octokit.rest.users.getByUsername = jest.fn().mockReturnValueOnce({
     status: 200,
     data: {
       type: 'Bot'
     }
   })
 
-  octokit.rest.apps.getRepoInstallation.mockReturnValueOnce({
+  octokit.rest.apps.getRepoInstallation = jest.fn().mockReturnValueOnce({
     status: 500
   })
 

dist/index.js

@@ -14,38 +14,33 @@ export async function validPermissions(octokit, context) {
   core.setOutput('actor', context.actor)
 
   // Get Actor Type from GitHub API
-  const userRes = await octokit.rest.users.getByUsername(
-    {
+  const userRes = await octokit.rest.users.getByUsername({
     username: context.actor
-    }
-  )
+  })
 
   if (userRes.status !== 200) {
     return `Fetch user details returns non-200 status: ${userRes.status}`
   }
 
-  const actorType = userRes.data.type; // "User" or "Bot"
-  core.info(`🔍 Detected actor type: ${actorType} (${context.actor})`);
+  const actorType = userRes.data.type // "User" or "Bot"
+  core.info(`🔍 Detected actor type: ${actorType} (${context.actor})`)
 
   // Handle GitHub Apps (Bots)
   if (actorType === 'Bot') {
     // Fetch installation details for the GitHub App
-    const installationRes = await octokit.rest.apps.getRepoInstallation(
-      {
-        owner: context.repo.owner,
-        repo: context.repo.repo
-      }
-    )
+    const installationRes = await octokit.rest.apps.getRepoInstallation({
+      ...context.repo
+    })
 
     if (installationRes.status !== 200) {
       return `Failed to fetch GitHub App installation details: Status ${installationRes.status}`
     }
 
-    const appPermissions = installationRes.data.permissions || {};
+    const appPermissions = installationRes.data.permissions || {}
 
     // Ensure the bot has "issues" permission set to "write"
     if (appPermissions.issues !== 'write') {
-      return `👋 __${context.actor}__ does not have "issues" permission set to "write". Current permissions: ${JSON.stringify(appPermissions)}`;
+      return `👋 __${context.actor}__ does not have "issues" permission set to "write". Current permissions: ${JSON.stringify(appPermissions)}`
     }
 
     return true