From 326731ee806c38809f8cc625492fdd203b6e5528 Mon Sep 17 00:00:00 2001 From: Adam Setch Date: Thu, 25 Dec 2025 07:58:57 +1000 Subject: [PATCH] fix(metric): use tooltip to improve reliability of rendering Signed-off-by: Adam Setch --- .../__snapshots__/Sidebar.test.tsx.snap | 42 +- .../__snapshots__/AppLayout.test.tsx.snap | 22 +- .../components/metrics/MetricGroup.tsx | 2 +- .../components/metrics/MetricPill.tsx | 32 +- .../__snapshots__/MetricGroup.test.tsx.snap | 4014 +++++++++++------ .../__snapshots__/MetricPill.test.tsx.snap | 250 +- .../AccountNotifications.test.tsx.snap | 404 +- .../NotificationFooter.test.tsx.snap | 1674 ++++--- .../NotificationRow.test.tsx.snap | 1376 +++--- .../RepositoryNotifications.test.tsx.snap | 36 - .../__snapshots__/Header.test.tsx.snap | 2 - .../__snapshots__/HoverButton.test.tsx.snap | 2 - .../SettingsFooter.test.tsx.snap | 2 +- .../__snapshots__/Filters.test.tsx.snap | 3 +- .../routes/__snapshots__/Login.test.tsx.snap | 6 - .../LoginWithOAuthApp.test.tsx.snap | 12 +- ...LoginWithPersonalAccessToken.test.tsx.snap | 12 +- .../__snapshots__/Settings.test.tsx.snap | 20 +- 18 files changed, 4703 insertions(+), 3208 deletions(-) diff --git a/src/renderer/components/__snapshots__/Sidebar.test.tsx.snap b/src/renderer/components/__snapshots__/Sidebar.test.tsx.snap index 81e172b63..76c3cca09 100644 --- a/src/renderer/components/__snapshots__/Sidebar.test.tsx.snap +++ b/src/renderer/components/__snapshots__/Sidebar.test.tsx.snap @@ -2,7 +2,7 @@ exports[`renderer/components/Sidebar.tsx Filter notifications highlight filters sidebar if any are saved 1`] = ` + ); }; diff --git a/src/renderer/components/metrics/__snapshots__/MetricGroup.test.tsx.snap b/src/renderer/components/metrics/__snapshots__/MetricGroup.test.tsx.snap index 6e9f90ca0..cfc9fac84 100644 --- a/src/renderer/components/metrics/__snapshots__/MetricGroup.test.tsx.snap +++ b/src/renderer/components/metrics/__snapshots__/MetricGroup.test.tsx.snap @@ -16,12 +16,249 @@ exports[`renderer/components/metrics/MetricGroup.tsx comment pills should render >
+ + + + + + + + +
+ + + + , + "container":
+
+
+
+ + + + + + +
-
-
-
- , - "container":
-
-
-
- -
- - - 2 - -
-
- -
- - - 1 - -
-
- -
- - - 1 - -
-
+ -
- - - 1 - -
+ aria-hidden="true" + class="prc-TooltipV2-Tooltip-tLeuB" + data-direction="s" + id="_r_h_" + popover="auto" + role="tooltip" + > + 1 comment
@@ -419,12 +539,249 @@ exports[`renderer/components/metrics/MetricGroup.tsx comment pills should render >
+ + + + + + + + +
+
+
+ + , + "container":
+
+
+
+ + + + + + +
-
-
-
- , - "container":
-
-
-
- -
- - - 2 - -
-
- -
- - - 1 - -
-
- -
- - - 1 - -
-
+ -
- - - 2 - -
+ aria-hidden="true" + class="prc-TooltipV2-Tooltip-tLeuB" + data-direction="s" + id="_r_m_" + popover="auto" + role="tooltip" + > + 2 comments
@@ -822,12 +1062,196 @@ exports[`renderer/components/metrics/MetricGroup.tsx comment pills should render >
+ + + + + + +
+
+
+ + , + "container":
+
+
+
+ + + + +
-
-
-
- , - "container":
-
-
-
- -
- - - 2 - -
-
- -
- - - 1 - -
-
- -
- - - 1 - -
-
+ +
@@ -1149,12 +1479,302 @@ exports[`renderer/components/metrics/MetricGroup.tsx label pills should render l >
+ + + + + + + + + + +
+
+ + + , + "container":
+
+
+
+ + + + + + + + +
-
-
-
- , - "container":
-
-
-
- -
- - - 2 - -
-
- -
- - - 1 - -
-
- -
- - - 1 - -
-
- -
- - - 2 - -
-
+ -
- - - 2 - -
+ aria-hidden="true" + class="prc-TooltipV2-Tooltip-tLeuB" + data-direction="s" + id="_r_s_" + popover="auto" + role="tooltip" + > + 🏷️ enhancement, 🏷️ good-first-issue
@@ -1630,12 +2108,196 @@ exports[`renderer/components/metrics/MetricGroup.tsx linked issue pills should r >
+ + + + + + +
+
+
+ + , + "container":
+
+
+
+ + + + +
-
-
-
- , - "container":
-
-
-
- -
- - - 2 - -
-
- -
- - - 1 - -
-
+ -
- - - 1 - -
+ aria-hidden="true" + class="prc-TooltipV2-Tooltip-tLeuB" + data-direction="s" + id="_r_8_" + popover="auto" + role="tooltip" + > + gitify-app requested changes
@@ -1958,34 +2526,218 @@ exports[`renderer/components/metrics/MetricGroup.tsx linked issue pills should r
- -
- + + 1 + +
+
+ + + + + + +
+
+
+ + , + "container":
+
+
+
+ + + + +
-
-
-
- , - "container":
-
-
-
+ -
- - - 1 - -
-
- -
- - - 1 - -
-
- -
- - - 1 - -
+ aria-hidden="true" + class="prc-TooltipV2-Tooltip-tLeuB" + data-direction="s" + id="_r_4_" + popover="auto" + role="tooltip" + > + gitify-app requested changes
@@ -2284,12 +2942,350 @@ exports[`renderer/components/metrics/MetricGroup.tsx milestone pills should rend >
+ + + + + + + + + + + + +
+
+
+ + , + "container":
+
+
+
+ + + + + + + + + + +
-
-
-
- , - "container":
-
-
-
- -
- - - 2 - -
-
- -
- - - 1 - -
-
- -
- - - 1 - -
-
- -
- - - 2 - -
-
- -
- - - 2 - -
-
+ -
- -
+ aria-hidden="true" + class="prc-TooltipV2-Tooltip-tLeuB" + data-direction="s" + id="_r_1a_" + popover="auto" + role="tooltip" + > + Milestone 1
@@ -2831,12 +3667,350 @@ exports[`renderer/components/metrics/MetricGroup.tsx milestone pills should rend >
+ + + + + + + + + + + + +
+
+
+ + , + "container":
+
+
+
+ + + + + + + + + + +
-
-
-
- , - "container":
-
-
-
- -
- - - 2 - -
-
- -
- - - 1 - -
-
- -
- - - 1 - -
-
+ -
- - - 2 - -
-
- -
- - - 2 - -
-
- -
- -
+ aria-hidden="true" + class="prc-TooltipV2-Tooltip-tLeuB" + data-direction="s" + id="_r_13_" + popover="auto" + role="tooltip" + > + Milestone 1
diff --git a/src/renderer/components/metrics/__snapshots__/MetricPill.test.tsx.snap b/src/renderer/components/metrics/__snapshots__/MetricPill.test.tsx.snap index 37c1d4046..64993852b 100644 --- a/src/renderer/components/metrics/__snapshots__/MetricPill.test.tsx.snap +++ b/src/renderer/components/metrics/__snapshots__/MetricPill.test.tsx.snap @@ -13,12 +13,83 @@ exports[`renderer/components/metrics/MetricPill.tsx should render with metric 1`
+ + +
+
+
+ , + "container":
+
+
+
-
-
- , - "container":
-
-
+
@@ -174,12 +204,78 @@ exports[`renderer/components/metrics/MetricPill.tsx should render without metric
+ + +
+
+ + , + "container":
+
+
+
-
-
- , - "container":
-
-
+
diff --git a/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap b/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap index 6eafe8951..920504776 100644 --- a/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap +++ b/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap @@ -23,7 +23,6 @@ exports[`renderer/components/notifications/AccountNotifications.tsx should rende data-wrap="nowrap" >
+ + + + @@ -1578,7 +1588,6 @@ exports[`renderer/components/notifications/AccountNotifications.tsx should rende data-wrap="nowrap" > + + @@ -2438,7 +2468,6 @@ exports[`renderer/components/notifications/AccountNotifications.tsx should rende data-wrap="nowrap" > + + @@ -224,81 +254,111 @@ exports[`renderer/components/notifications/NotificationFooter.tsx security alert
- -
- - - 1 - -
-
+ + + 1 + +
+ + + + @@ -432,83 +492,113 @@ exports[`renderer/components/notifications/NotificationFooter.tsx security alert
- -
- - - 1 - -
-
+ + + 1 + +
+ + - + + + 1 + + + + + + @@ -583,81 +673,111 @@ exports[`renderer/components/notifications/NotificationFooter.tsx security alert
- -
- - - 1 - -
-
+ + + 1 + +
+ + + + @@ -792,81 +912,111 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should default
- -
- - - 1 - -
-
+ + + 1 + +
+ + + + @@ -944,85 +1094,115 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should default
- -
- - - 1 - -
-
+ + + 1 + +
+ + - - - + + + + + , "debug": [Function], @@ -1152,81 +1332,111 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should render
- -
- - - 1 - -
-
+ + + 1 + +
+ + + + @@ -1303,81 +1513,111 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should render
- -
- - - 1 - -
-
+ + + 1 + +
+ + + + @@ -1511,81 +1751,111 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should render
- -
- - - 1 - -
-
+ + + 1 + +
+ + + + @@ -1662,81 +1932,111 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should render
- -
- - - 1 - -
-
+ + + 1 + +
+ + + + diff --git a/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap b/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap index a53d3105c..8227203cc 100644 --- a/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap +++ b/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap @@ -202,81 +202,111 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
- -
- - - 1 - -
-
+ + + 1 + +
+ + + + @@ -292,7 +322,6 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its data-wrap="nowrap" > + + @@ -675,7 +732,6 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its data-wrap="nowrap" > + + @@ -1063,7 +1147,6 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its data-wrap="nowrap" > + + @@ -1394,7 +1505,6 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its data-wrap="nowrap" > + + @@ -1782,7 +1920,6 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its data-wrap="nowrap" > + + @@ -2113,7 +2278,6 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its data-wrap="nowrap" > + + @@ -2501,7 +2693,6 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its data-wrap="nowrap" > + + @@ -2832,7 +3051,6 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its data-wrap="nowrap" >