* Updated to new lint rules (globals and inits)

* Fixes following scope lint checker

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>

Author: fredbi

contact_info_test.go

@@ -18,11 +18,12 @@ import (
 	"testing"
 )
 
-var contactInfoJSON = `{"name":"wordnik api team","url":"http://developer.wordnik.com","email":"some@mailayada.dkdkd"}`
-var contactInfoYAML = `name: wordnik api team
+const contactInfoJSON = `{"name":"wordnik api team","url":"http://developer.wordnik.com","email":"some@mailayada.dkdkd"}`
+const contactInfoYAML = `name: wordnik api team
 url: http://developer.wordnik.com
 email: some@mailayada.dkdkd
 `
+
 var contactInfo = ContactInfo{
 	Name:  "wordnik api team",
 	URL:   "http://developer.wordnik.com",

expander.go

@@ -168,22 +168,25 @@ func ExpandSpec(spec *Swagger, options *ExpandOptions) error {
 		}
 	}
 
-	for key, parameter := range spec.Parameters {
+	for key := range spec.Parameters {
+		parameter := spec.Parameters[key]
 		if err := expandParameterOrResponse(&parameter, resolver, specBasePath); resolver.shouldStopOnError(err) {
 			return err
 		}
 		spec.Parameters[key] = parameter
 	}
 
-	for key, response := range spec.Responses {
+	for key := range spec.Responses {
+		response := spec.Responses[key]
 		if err := expandParameterOrResponse(&response, resolver, specBasePath); resolver.shouldStopOnError(err) {
 			return err
 		}
 		spec.Responses[key] = response
 	}
 
 	if spec.Paths != nil {
-		for key, path := range spec.Paths.Paths {
+		for key := range spec.Paths.Paths {
+			path := spec.Paths.Paths[key]
 			if err := expandPathItem(&path, resolver, specBasePath); resolver.shouldStopOnError(err) {
 				return err
 			}
@@ -485,7 +488,8 @@ func expandOperation(op *Operation, resolver *schemaLoader, basePath string) err
 		return nil
 	}
 
-	for i, param := range op.Parameters {
+	for i := range op.Parameters {
+		param := op.Parameters[i]
 		if err := expandParameterOrResponse(&param, resolver, basePath); resolver.shouldStopOnError(err) {
 			return err
 		}
@@ -497,7 +501,8 @@ func expandOperation(op *Operation, resolver *schemaLoader, basePath string) err
 		if err := expandParameterOrResponse(responses.Default, resolver, basePath); resolver.shouldStopOnError(err) {
 			return err
 		}
-		for code, response := range responses.StatusCodeResponses {
+		for code := range responses.StatusCodeResponses {
+			response := responses.StatusCodeResponses[code]
 			if err := expandParameterOrResponse(&response, resolver, basePath); resolver.shouldStopOnError(err) {
 				return err
 			}

header_test.go

@@ -57,7 +57,7 @@ var header = Header{
 	},
 }
 
-var headerJSON = `{
+const headerJSON = `{
   "items": {
     "$ref": "Cat"
   },

info_test.go

@@ -21,7 +21,7 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-var infoJSON = `{
+const infoJSON = `{
 	"description": "A sample API that uses a petstore as an example to demonstrate features in ` +
 	`the swagger-2.0 specification",
 	"title": "Swagger Sample API",

items_test.go

@@ -48,7 +48,7 @@ var items = Items{
 	},
 }
 
-var itemsJSON = `{
+const itemsJSON = `{
 	"items": {
 		"$ref": "Cat"
 	},

operation.go

@@ -18,6 +18,7 @@ import (
 	"bytes"
 	"encoding/gob"
 	"encoding/json"
+	"sort"
 
 	"github.com/go-openapi/jsonpointer"
 	"github.com/go-openapi/swag"
@@ -88,11 +89,17 @@ func (o *Operation) SuccessResponse() (*Response, int, bool) {
 		return nil, 0, false
 	}
 
-	for k, v := range o.Responses.StatusCodeResponses {
-		if k/100 == 2 {
-			return &v, k, true
+	responseCodes := make([]int, 0, len(o.Responses.StatusCodeResponses))
+	for k := range o.Responses.StatusCodeResponses {
+		if k >= 200 && k < 300 {
+			responseCodes = append(responseCodes, k)
 		}
 	}
+	if len(responseCodes) > 0 {
+		sort.Ints(responseCodes)
+		v := o.Responses.StatusCodeResponses[responseCodes[0]]
+		return &v, responseCodes[0], true
+	}
 
 	return o.Responses.Default, 0, false
 }

operation_test.go

@@ -58,7 +58,7 @@ var operation = Operation{
 	},
 }
 
-var operationJSON = `{
+const operationJSON = `{
 	"description": "operation description",
 	"x-framework": "go-swagger",
 	"consumes": [ "application/json", "application/x-yaml" ],

path_item_test.go

@@ -58,7 +58,7 @@ var pathItem = PathItem{
 	},
 }
 
-var pathItemJSON = `{
+const pathItemJSON = `{
 	"$ref": "Dog",
 	"x-framework": "go-swagger",
 	"get": { "description": "get operation description" },

paths_test.go

@@ -30,7 +30,7 @@ var paths = Paths{
 	},
 }
 
-var pathsJSON = `{"x-framework":"go-swagger","/":{"$ref":"cats"}}`
+const pathsJSON = `{"x-framework":"go-swagger","/":{"$ref":"cats"}}`
 
 func TestIntegrationPaths(t *testing.T) {
 	var actual Paths

response_test.go

@@ -34,7 +34,7 @@ var response = Response{
 	},
 }
 
-var responseJSON = `{
+const responseJSON = `{
 	"$ref": "Dog",
 	"x-go-name": "PutDogExists",
 	"description": "Dog exists",