Add tests to cover remaining EasyPermissions methods

Author: Henrique Faria

easypermissions/src/test/java/pub/devrel/easypermissions/EasyPermissionsLowApiTest.java

@@ -2,6 +2,7 @@
 
 import android.Manifest;
 
+import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -12,8 +13,9 @@
 import org.robolectric.Robolectric;
 import org.robolectric.RobolectricTestRunner;
 import org.robolectric.RuntimeEnvironment;
+import org.robolectric.android.controller.ActivityController;
+import org.robolectric.android.controller.FragmentController;
 import org.robolectric.annotation.Config;
-import org.robolectric.shadows.ShadowApplication;
 import org.robolectric.shadows.support.v4.SupportFragmentController;
 
 import java.util.ArrayList;
@@ -33,14 +35,16 @@
 @Config(sdk = 19)
 public class EasyPermissionsLowApiTest {
 
-    private static final int REQUEST_CODE = 5;
     private static final String RATIONALE = "RATIONALE";
     private static final String[] ALL_PERMS = new String[]{
             Manifest.permission.READ_SMS, Manifest.permission.ACCESS_FINE_LOCATION};
 
     private TestActivity spyActivity;
     private TestFragment spyFragment;
     private TestSupportFragment spySupportFragment;
+    private ActivityController<TestActivity> activityController;
+    private FragmentController<TestFragment> fragmentController;
+    private SupportFragmentController<TestSupportFragment> supportFragmentController;
     @Captor
     private ArgumentCaptor<Integer> integerCaptor;
     @Captor
@@ -52,52 +56,71 @@ public void setUp() {
         setUpActivityAndFragment();
     }
 
+    @After
+    public void tearDown() {
+        tearDownActivityAndFragment();
+    }
+
+    // ------ General tests ------
+
     @Test
     public void shouldHavePermission_whenHasPermissionsBeforeMarshmallow() {
         assertThat(EasyPermissions.hasPermissions(RuntimeEnvironment.application,
                 Manifest.permission.ACCESS_COARSE_LOCATION)).isTrue();
     }
 
+    // ------ From Activity ------
+
     @Test
     public void shouldCallbackOnPermissionGranted_whenRequestFromActivity() {
-        EasyPermissions.requestPermissions(spyActivity, RATIONALE, REQUEST_CODE, ALL_PERMS);
+        EasyPermissions.requestPermissions(spyActivity, RATIONALE, TestActivity.REQUEST_CODE, ALL_PERMS);
 
         verify(spyActivity, times(1))
                 .onPermissionsGranted(integerCaptor.capture(), listCaptor.capture());
-        assertThat(integerCaptor.getValue()).isEqualTo(REQUEST_CODE);
+        assertThat(integerCaptor.getValue()).isEqualTo(TestActivity.REQUEST_CODE);
         assertThat(listCaptor.getValue()).containsAllIn(ALL_PERMS);
     }
 
+    // ------ From Fragment ------
+
     @Test
     public void shouldCallbackOnPermissionGranted_whenRequestFromFragment() {
-        EasyPermissions.requestPermissions(spyFragment, RATIONALE, REQUEST_CODE, ALL_PERMS);
+        EasyPermissions.requestPermissions(spyFragment, RATIONALE, TestFragment.REQUEST_CODE, ALL_PERMS);
 
         verify(spyFragment, times(1))
                 .onPermissionsGranted(integerCaptor.capture(), listCaptor.capture());
-        assertThat(integerCaptor.getValue()).isEqualTo(REQUEST_CODE);
+        assertThat(integerCaptor.getValue()).isEqualTo(TestFragment.REQUEST_CODE);
         assertThat(listCaptor.getValue()).containsAllIn(ALL_PERMS);
     }
 
+    // ------ From Support Fragment ------
+
     @Test
     public void shouldCallbackOnPermissionGranted_whenRequestFromSupportedFragment() {
-        EasyPermissions.requestPermissions(spySupportFragment, RATIONALE, REQUEST_CODE, ALL_PERMS);
+        EasyPermissions.requestPermissions(spySupportFragment, RATIONALE, TestSupportFragment.REQUEST_CODE, ALL_PERMS);
 
         verify(spySupportFragment, times(1))
                 .onPermissionsGranted(integerCaptor.capture(), listCaptor.capture());
-        assertThat(integerCaptor.getValue()).isEqualTo(REQUEST_CODE);
+        assertThat(integerCaptor.getValue()).isEqualTo(TestSupportFragment.REQUEST_CODE);
         assertThat(listCaptor.getValue()).containsAllIn(ALL_PERMS);
     }
 
     private void setUpActivityAndFragment() {
-        TestActivity activity = Robolectric.buildActivity(TestActivity.class)
-                .create().start().resume().get();
-        TestFragment fragment = Robolectric.buildFragment(TestFragment.class)
-                .create().start().resume().get();
-        TestSupportFragment supportFragment = SupportFragmentController.of(new TestSupportFragment())
-                .create().start().resume().get();
-
-        spyActivity = Mockito.spy(activity);
-        spyFragment = Mockito.spy(fragment);
-        spySupportFragment = Mockito.spy(supportFragment);
+        activityController = Robolectric.buildActivity(TestActivity.class)
+                .create().start().resume();
+        fragmentController = Robolectric.buildFragment(TestFragment.class)
+                .create().start().resume();
+        supportFragmentController = SupportFragmentController.of(new TestSupportFragment())
+                .create().start().resume();
+
+        spyActivity = Mockito.spy(activityController.get());
+        spyFragment = Mockito.spy(fragmentController.get());
+        spySupportFragment = Mockito.spy(supportFragmentController.get());
+    }
+
+    private void tearDownActivityAndFragment() {
+        activityController.pause().stop().destroy();
+        fragmentController.pause().stop().destroy();
+        supportFragmentController.pause().stop().destroy();
     }
 }