Skip to content

Commit 9ac72f7

Browse files
committed
Fix - UserOptions - Fix name collision & simplify toggle event management (#221)
1 parent 539c603 commit 9ac72f7

File tree

1 file changed

+10
-22
lines changed

1 file changed

+10
-22
lines changed

src/atoms/UserOptions.vue

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -255,33 +255,21 @@ function toggleTooltip() {
255255
}
256256
}
257257
258-
const isFullscreen = ref(false);
258+
const _isFullscreen = ref(props.isFullscreen);
259259
260-
function toggleFullscreen(state) {
261-
if (props.callbacks.fullscreen) {
262-
props.callbacks.fullscreen();
260+
async function toggleFullscreen() {
261+
if (!props.chartElement) return;
262+
if (_isFullscreen.value) {
263+
document.exitFullscreen();
263264
} else {
264-
if(!props.chartElement) return;
265-
if(state === "in") {
266-
isFullscreen.value = true;
267-
props.chartElement.requestFullscreen();
268-
emit('toggleFullscreen', true);
269-
}else {
270-
isFullscreen.value = false;
271-
document && document.exitFullscreen();
272-
emit('toggleFullscreen', false);
273-
}
265+
await props.chartElement.requestFullscreen();
274266
}
275267
}
276268
277-
function fullscreenchanged(_event) {
278-
if (document.fullscreenElement) {
279-
isFullscreen.value = true;
280-
emit('toggleFullscreen', true);
281-
} else {
282-
isFullscreen.value = false;
283-
emit('toggleFullscreen', false);
284-
}
269+
function fullscreenchanged() {
270+
const flag = !!document.fullscreenElement;
271+
_isFullscreen.value = flag;
272+
emit('toggleFullscreen', flag);
285273
}
286274
287275
onMounted(() => {

0 commit comments

Comments
 (0)