Merge pull request #1644 from adumesny/develop

collsion: restored place across

Author: adumesny

spec/e2e/html/141_1534_swap.html

@@ -79,6 +79,7 @@ <h1>Swap collision demo</h1>
     };
 
     load = function(i) {
+      layout = i;
       grid.removeAll();
       grid.load(items[i]);
     }
@@ -103,9 +104,9 @@ <h1>Swap collision demo</h1>
       setSize(size);
     }
     setSize = function(size) {
-      items.sort((a,b) => a.id - b.id);
-      items.forEach((n,i) => {
-        if (i<6) {
+      items[layout].sort((a,b) => a.id - b.id);
+      items[layout].forEach((n,i) => {
+        if (layout === 0 && i<6) {
           n.w = n.h = size;
           n.y = i * size;
           if (n.x) n.x = size;
@@ -114,7 +115,7 @@ <h1>Swap collision demo</h1>
         }
       });
       grid.opts.maxRow = grid.engine.maxRow = grid.opts.maxRow ? (size === 1 ? 3 : 6) : 0;
-      grid.load(items);
+      grid.load(items[layout]);
       bigButton.innerHTML = 'Size: ' + size;
       maxButton.innerHTML = 'Max: ' + grid.opts.maxRow;
     }

src/gridstack-engine.ts

@@ -91,16 +91,19 @@ export class GridStackEngine {
       // (not handled with swap) that could take our place, move ourself past it instead
       // but remember that skip down so we only do this one (and push others otherwise).
       if (collide.locked || (node._moving && !node._skipDown && nn.y > node.y &&
-        !this.float && !this.collide(collide, {...collide, y: node.y}, node)) &&
-        Utils.isIntercepted(collide, {x: node.x-0.5, y: node.y-0.5, w: node.w+1, h: node.h+1})) {
+        !this.float && !this.collide(collide, {...collide, y: node.y}, node)) && Utils.isTouching(node, collide)) {
 
         node._skipDown = (node._skipDown || nn.y > node.y);
         moved = this.moveNode(node, {...nn, y: collide.y + collide.h, ...newOpt});
         if (collide.locked && moved) {
           Utils.copyPos(nn, node); // moving after lock become our new desired location
         } else if (moved && opt.pack && !collide.locked) {
-          // we moved after and will pack: do it now and keep the original drop location to see what else we might push way
+          // we moved after and will pack: do it now and keep the original drop location, but past the old collide to see what else we might push way
           this._packNodes();
+          if (moved) {
+            nn.y = collide.y + collide.h;
+            Utils.copyPos(node, nn);
+          }
         }
         didMove = didMove || moved;
       } else {
@@ -197,19 +200,15 @@ export class GridStackEngine {
       a._dirty = b._dirty = true;
       return true;
     }
-    // make sure they at least touch (including corners which will skip below as unwanted)
-    function _touching(): boolean {
-      return Utils.isIntercepted(a, {x: b.x-0.5, y:b.y-0.5, w: b.w+1, h: b.h+1})
-    }
     let touching: boolean; // remember if we called it (vs undefined)
 
     // same size and same row or column, and touching
-    if (a.w === b.w && a.h === b.h && (a.x === b.x || a.y === b.y) && (touching = _touching()))
+    if (a.w === b.w && a.h === b.h && (a.x === b.x || a.y === b.y) && (touching = Utils.isTouching(a, b)))
       return _doSwap();
     if (touching === false) return; // ran test and fail, bail out
 
     // check for taking same columns (but different height) and touching
-    if (a.w === b.w && a.x === b.x && (touching || _touching())) {
+    if (a.w === b.w && a.x === b.x && (touching || Utils.isTouching(a, b))) {
       if (b.y < a.y) { let t = a; a = b; b = t; } // swap a <-> b vars so a is first
       return _doSwap();
     }

src/utils.ts

@@ -99,6 +99,10 @@ export class Utils {
     return !(a.y >= b.y + b.h || a.y + a.h <= b.y || a.x + a.w <= b.x || a.x >= b.x + b.w);
   }
 
+  /** returns true if a and b touch edges or corners */
+  static isTouching(a: GridStackPosition, b: GridStackPosition): boolean {
+    return Utils.isIntercepted(a, {x: b.x-0.5, y: b.y-0.5, w: b.w+1, h: b.h+1})
+  }
   /**
    * Sorts array of nodes
    * @param nodes array to sort